Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759957AbbKTLYV (ORCPT ); Fri, 20 Nov 2015 06:24:21 -0500 Received: from smtp.citrix.com ([66.165.176.89]:48252 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759922AbbKTLYS (ORCPT ); Fri, 20 Nov 2015 06:24:18 -0500 X-IronPort-AV: E=Sophos;i="5.20,322,1444694400"; d="scan'208";a="313618619" Date: Fri, 20 Nov 2015 11:24:02 +0000 From: Stefano Stabellini X-X-Sender: sstabellini@kaball.uk.xensource.com To: Boris Ostrovsky CC: , , , , , , , , , , Catalin Marinas , "Will Deacon" Subject: Re: [PATCH v2] xen/events: Always allocate legacy interrupts on PV guests In-Reply-To: <1447870445-17199-1-git-send-email-boris.ostrovsky@oracle.com> Message-ID: References: <1447870445-17199-1-git-send-email-boris.ostrovsky@oracle.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2596 Lines: 78 On Wed, 18 Nov 2015, Boris Ostrovsky wrote: > After commit 8c058b0b9c34 ("x86/irq: Probe for PIC presence before > allocating descs for legacy IRQs") early_irq_init() will no longer > preallocate descriptors for legacy interrupts if PIC does not > exist, which is the case for Xen PV guests. > > Therefore we may need to allocate those descriptors ourselves. > > Signed-off-by: Boris Ostrovsky > Suggested-by: Thomas Gleixner You need to do this for arm64 too. FYI you can download arm64 cross-compilers from https://releases.linaro.org/14.04/components/toolchain/binaries/ then you can use them by exporting ARCH=arm64 and CROSS_COMPILE=/path/to/gcc-linaro-aarch64-linux-gnu-version/bin/aarch64-linux-gnu- > v2: Use nr_legacy_irqs() instead of NR_IRQS_LEGACY (needs definition for ARM) > > arch/arm/include/asm/irq.h | 4 ++++ > drivers/xen/events/events_base.c | 5 +++-- > 2 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/include/asm/irq.h b/arch/arm/include/asm/irq.h > index be1d07d..b864f60 100644 > --- a/arch/arm/include/asm/irq.h > +++ b/arch/arm/include/asm/irq.h > @@ -2,6 +2,10 @@ > #define __ASM_ARM_IRQ_H > > #define NR_IRQS_LEGACY 16 > +static inline int nr_legacy_irqs(void) > +{ > + return NR_IRQS_LEGACY; > +} > > #ifndef CONFIG_SPARSE_IRQ > #include > diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_base.c > index 849500e..524c221 100644 > --- a/drivers/xen/events/events_base.c > +++ b/drivers/xen/events/events_base.c > @@ -39,6 +39,7 @@ > #include > #include > #include > +#include > #include > #endif > #include > @@ -420,7 +421,7 @@ static int __must_check xen_allocate_irq_gsi(unsigned gsi) > return xen_allocate_irq_dynamic(); > > /* Legacy IRQ descriptors are already allocated by the arch. */ > - if (gsi < NR_IRQS_LEGACY) > + if (gsi < nr_legacy_irqs()) > irq = gsi; > else > irq = irq_alloc_desc_at(gsi, -1); > @@ -446,7 +447,7 @@ static void xen_free_irq(unsigned irq) > kfree(info); > > /* Legacy IRQ descriptors are managed by the arch. */ > - if (irq < NR_IRQS_LEGACY) > + if (irq < nr_legacy_irqs()) > return; > > irq_free_desc(irq); > -- > 2.1.0 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/