Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760055AbbKTMPk (ORCPT ); Fri, 20 Nov 2015 07:15:40 -0500 Received: from icp-osb-irony-out6.external.iinet.net.au ([203.59.1.106]:20734 "EHLO icp-osb-irony-out6.external.iinet.net.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759452AbbKTMPi (ORCPT ); Fri, 20 Nov 2015 07:15:38 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApsBAPENT1Y6B8IR/2dsb2JhbAANUYR9q3wBAQEBAQEGkGqEDYYPAoIXAQEBAQEBhT8BAQEEOEABEAsNAQMDAQIBCRYPCQMCAQIBDy4IBgEMBgIBAYgVA68IjDUNhHQBAQEBAQEBAQEBAQEBAQEBAQEbhg2FRYJThmYBBJZMizgBiyyFeIVLh1ODJ4FSYAGFLAEBAQ X-IronPort-AV: E=Sophos;i="5.20,322,1444665600"; d="scan'208";a="194460597" Subject: Re: [PATCH] include: asm-generic: page.h: Remove useless get_user_page and free_user_page To: Chen Gang , "vgupta@synopsys.com" , "dhowells@redhat.com" , "linux@arm.linux.org.uk" , "geert@linux-m68k.org" , "jonas@southpole.se" , Arnd Bergmann , "abrodkin@synopsys.com" , Andrew Morton References: Cc: "linux-snps-arc@lists.infradead.org" , kernel mailing list , "linux-arm-kernel@lists.infradead.org" , "linux-m68k@lists.linux-m68k.org" , "linux-arch@vger.kernel.org" , linux@lists.openrisc.net From: Greg Ungerer Message-ID: <564F0ECD.2050109@uclinux.org> Date: Fri, 20 Nov 2015 22:15:09 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4731 Lines: 141 Hi Chen, On 19/11/15 05:40, Chen Gang wrote: >>From ba7c00c4cb976109b6a35812ce9649aaeda81e2d Mon Sep 17 00:00:00 2001 > From: Chen Gang > Date: Thu, 19 Nov 2015 03:24:42 +0800 > Subject: [PATCH] include: asm-generic: page.h: Remove useless get_user_page and free_user_page > > They are not symmetric with each other, neither are used in real world > (can not be found by grep command in source code root directory), so > remove them. > > Signed-off-by: Chen Gang Compile and run tested on m68k (MMU and noMMU) targets. No problems found. So for those parts: Acked-by: Greg Ungerer Regards Greg > --- > arch/arc/include/asm/page.h | 3 --- > arch/arm/include/asm/page-nommu.h | 3 --- > arch/frv/include/asm/page.h | 3 --- > arch/m68k/include/asm/page_mm.h | 3 --- > arch/m68k/include/asm/page_no.h | 3 --- > arch/openrisc/include/asm/page.h | 3 --- > include/asm-generic/page.h | 3 --- > 7 files changed, 21 deletions(-) > > diff --git a/arch/arc/include/asm/page.h b/arch/arc/include/asm/page.h > index 429957f..adf5cbb 100644 > --- a/arch/arc/include/asm/page.h > +++ b/arch/arc/include/asm/page.h > @@ -13,9 +13,6 @@ > > #ifndef __ASSEMBLY__ > > -#define get_user_page(vaddr) __get_free_page(GFP_KERNEL) > -#define free_user_page(page, addr) free_page(addr) > - > #define clear_page(paddr) memset((paddr), 0, PAGE_SIZE) > #define copy_page(to, from) memcpy((to), (from), PAGE_SIZE) > > diff --git a/arch/arm/include/asm/page-nommu.h b/arch/arm/include/asm/page-nommu.h > index d1b162a..503f488 100644 > --- a/arch/arm/include/asm/page-nommu.h > +++ b/arch/arm/include/asm/page-nommu.h > @@ -17,9 +17,6 @@ > #define KTHREAD_SIZE PAGE_SIZE > #endif > > -#define get_user_page(vaddr) __get_free_page(GFP_KERNEL) > -#define free_user_page(page, addr) free_page(addr) > - > #define clear_page(page) memset((page), 0, PAGE_SIZE) > #define copy_page(to,from) memcpy((to), (from), PAGE_SIZE) > > diff --git a/arch/frv/include/asm/page.h b/arch/frv/include/asm/page.h > index 8c97068..52ace96 100644 > --- a/arch/frv/include/asm/page.h > +++ b/arch/frv/include/asm/page.h > @@ -8,9 +8,6 @@ > > #ifndef __ASSEMBLY__ > > -#define get_user_page(vaddr) __get_free_page(GFP_KERNEL) > -#define free_user_page(page, addr) free_page(addr) > - > #define clear_page(pgaddr) memset((pgaddr), 0, PAGE_SIZE) > #define copy_page(to,from) memcpy((to), (from), PAGE_SIZE) > > diff --git a/arch/m68k/include/asm/page_mm.h b/arch/m68k/include/asm/page_mm.h > index 5029f73..e7a1946 100644 > --- a/arch/m68k/include/asm/page_mm.h > +++ b/arch/m68k/include/asm/page_mm.h > @@ -6,9 +6,6 @@ > #include > #include > > -#define get_user_page(vaddr) __get_free_page(GFP_KERNEL) > -#define free_user_page(page, addr) free_page(addr) > - > /* > * We don't need to check for alignment etc. > */ > diff --git a/arch/m68k/include/asm/page_no.h b/arch/m68k/include/asm/page_no.h > index ef20916..fa7f32d 100644 > --- a/arch/m68k/include/asm/page_no.h > +++ b/arch/m68k/include/asm/page_no.h > @@ -6,9 +6,6 @@ > extern unsigned long memory_start; > extern unsigned long memory_end; > > -#define get_user_page(vaddr) __get_free_page(GFP_KERNEL) > -#define free_user_page(page, addr) free_page(addr) > - > #define clear_page(page) memset((page), 0, PAGE_SIZE) > #define copy_page(to,from) memcpy((to), (from), PAGE_SIZE) > > diff --git a/arch/openrisc/include/asm/page.h b/arch/openrisc/include/asm/page.h > index 108906f..e613d36 100644 > --- a/arch/openrisc/include/asm/page.h > +++ b/arch/openrisc/include/asm/page.h > @@ -40,9 +40,6 @@ > > #ifndef __ASSEMBLY__ > > -#define get_user_page(vaddr) __get_free_page(GFP_KERNEL) > -#define free_user_page(page, addr) free_page(addr) > - > #define clear_page(page) memset((page), 0, PAGE_SIZE) > #define copy_page(to, from) memcpy((to), (from), PAGE_SIZE) > > diff --git a/include/asm-generic/page.h b/include/asm-generic/page.h > index 37d1fe2..67cfb7d 100644 > --- a/include/asm-generic/page.h > +++ b/include/asm-generic/page.h > @@ -24,9 +24,6 @@ > > #ifndef __ASSEMBLY__ > > -#define get_user_page(vaddr) __get_free_page(GFP_KERNEL) > -#define free_user_page(page, addr) free_page(addr) > - > #define clear_page(page) memset((page), 0, PAGE_SIZE) > #define copy_page(to,from) memcpy((to), (from), PAGE_SIZE) > > -- > 1.9.3 > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/