Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760077AbbKTMUF (ORCPT ); Fri, 20 Nov 2015 07:20:05 -0500 Received: from smtp.citrix.com ([66.165.176.89]:61504 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760010AbbKTMT7 (ORCPT ); Fri, 20 Nov 2015 07:19:59 -0500 X-IronPort-AV: E=Sophos;i="5.20,322,1444694400"; d="scan'208";a="313627512" Date: Fri, 20 Nov 2015 12:19:43 +0000 From: Stefano Stabellini X-X-Sender: sstabellini@kaball.uk.xensource.com To: Will Deacon CC: Marc Zyngier , Stefano Stabellini , , , , , , , , , , , Subject: Re: [PATCH v11 4/5] arm64: introduce CONFIG_PARAVIRT, PARAVIRT_TIME_ACCOUNTING and pv_time_ops In-Reply-To: <20151117173557.GN30101@arm.com> Message-ID: References: <1446737696-9749-4-git-send-email-stefano.stabellini@eu.citrix.com> <20151117172914.GL30101@arm.com> <564B652C.8060409@arm.com> <20151117173557.GN30101@arm.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-DLP: MIA2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2229 Lines: 65 On Tue, 17 Nov 2015, Will Deacon wrote: > On Tue, Nov 17, 2015 at 05:34:36PM +0000, Marc Zyngier wrote: > > On 17/11/15 17:29, Will Deacon wrote: > > > On Tue, Nov 10, 2015 at 02:11:38PM +0000, Stefano Stabellini wrote: > > >> On Thu, 5 Nov 2015, Stefano Stabellini wrote: > > >>> Introduce CONFIG_PARAVIRT and PARAVIRT_TIME_ACCOUNTING on ARM64. > > >>> Necessary duplication of paravirt.h and paravirt.c with ARM. > > >>> > > >>> The only paravirt interface supported is pv_time_ops.steal_clock, so no > > >>> runtime pvops patching needed. > > >>> > > >>> This allows us to make use of steal_account_process_tick for stolen > > >>> ticks accounting. > > >>> > > >>> Signed-off-by: Stefano Stabellini > > >>> Acked-by: Marc Zyngier > > >> > > >> Ping? > > >> > > >> Catalin, Will, > > >> are you happy with this change? > > > > > > I'm happy if Marc's happy. Marc? > > > > My Ack is already on the tin! ;-) > > Ah yes, I only saw the cc line. In which case, I assume Stefano will > take this via the xen tree. Unfortunately I am still missing Russell's ack on the arm patch (3/5). Would you be OK if I dropped stolen time support for arm, only keeping the arm64 part? The price to pay is two small ifdefs in arch/arm/xen/enlighten.c: diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c index 15621b1..87e2fec 100644 --- a/arch/arm/xen/enlighten.c +++ b/arch/arm/xen/enlighten.c @@ -16,7 +16,9 @@ #include #include #include +#ifdef ARM64 #include +#endif #include #include #include @@ -289,9 +291,10 @@ static int __init xen_guest_init(void) register_cpu_notifier(&xen_cpu_notifier); +#ifdef ARM64 pv_time_ops.steal_clock = xen_stolen_accounting; static_key_slow_inc(¶virt_steal_enabled); - +#endif return 0; } early_initcall(xen_guest_init); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/