Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760143AbbKTMk1 (ORCPT ); Fri, 20 Nov 2015 07:40:27 -0500 Received: from unicorn.mansr.com ([81.2.72.234]:54361 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754664AbbKTMk0 convert rfc822-to-8bit (ORCPT ); Fri, 20 Nov 2015 07:40:26 -0500 From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Marc Gonzalez Cc: Valentin Rothberg , , , , Paul Bolle , Andreas Ziegler , Arnd Bergmann , Kevin Hilman , Olof Johansson , Rob Herring Subject: Re: clk: tango4: undefined CONFIG_ARCH_TANGOX References: <20151120085039.GA2832@debian-vm> <564EEB0F.9000208@sigmadesigns.com> Date: Fri, 20 Nov 2015 12:40:23 +0000 In-Reply-To: <564EEB0F.9000208@sigmadesigns.com> (Marc Gonzalez's message of "Fri, 20 Nov 2015 10:42:39 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1660 Lines: 48 Marc Gonzalez writes: > On 20/11/2015 09:50, Valentin Rothberg wrote: > >> your commit ed12dfc92f01 ("clk: tango4: clkgen driver for Tango4 >> platforms") has shown up in today's linux-next tree (i.e., >> next-20151120) adding the following build condition to the tango4 clk >> driver: >> >> drivers/clk/Makefile:45:obj-$(CONFIG_ARCH_TANGOX) += clk-tango4.o >> >> However, ARCH_TANGOX is nowhere defined in Kconfig so that the driver >> cannot be compiled at the current state. I checked the LKML, and found >> a bunch of patches referencing ARCH_TANGOX as well, but I could not find >> any patch adding this option. >> >> Is there a patch queued somewhere that adds ARCH_TANGOX? > > Hello Valentin, > > Platform support has not been accepted yet. > > http://thread.gmane.org/gmane.linux.ports.arm.kernel/456280 > > In fact, Kevin Hilman has pointed out that the arch should not > be called TANGOX, because X is a wildcard. > > (However, several unrelated drivers have been submitted with > TANGOX in the name. Is that a problem?) > > tango3 was a MIPS-based design > tango4 is an ARM-based design (with one MIPS-based outlier). > tango5 is an ARM-based design > > Although Mans is against the idea, I believe there should be one > different clk driver for each arch. It's essentially the same clock generator. It should be a single driver. -- M?ns Rullg?rd mans@mansr.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/