Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162691AbbKTMpP (ORCPT ); Fri, 20 Nov 2015 07:45:15 -0500 Received: from mail-wm0-f46.google.com ([74.125.82.46]:33228 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760164AbbKTMpL (ORCPT ); Fri, 20 Nov 2015 07:45:11 -0500 Message-ID: <564F15D4.4010508@lightnvm.io> Date: Fri, 20 Nov 2015 13:45:08 +0100 From: =?windows-1252?Q?Matias_Bj=F8rling?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Wenwei Tao CC: linux-kernel@vger.kernel.org Subject: Re: [PATCH] nvme: lightnvm: use nvme admin queue References: <1448000896-4526-1-git-send-email-ww.tao0320@gmail.com> In-Reply-To: <1448000896-4526-1-git-send-email-ww.tao0320@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2577 Lines: 64 On 11/20/2015 07:28 AM, Wenwei Tao wrote: > According to Open-ChannelSSDInterfaceSpecification 0.1, > NVMe-NVM admin commands use vendor specific admin opcodes > of NVMe, so use the NVMe admin queue to dispatch these > commands > > Signed-off-by: Wenwei Tao > --- > drivers/nvme/host/lightnvm.c | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/drivers/nvme/host/lightnvm.c b/drivers/nvme/host/lightnvm.c > index e0b7b95..7d1981d 100644 > --- a/drivers/nvme/host/lightnvm.c > +++ b/drivers/nvme/host/lightnvm.c > @@ -244,6 +244,7 @@ static int init_grps(struct nvm_id *nvm_id, struct nvme_nvm_id *nvme_nvm_id) > static int nvme_nvm_identity(struct request_queue *q, struct nvm_id *nvm_id) > { > struct nvme_ns *ns = q->queuedata; > + struct nvme_dev *dev = ns->dev; > struct nvme_nvm_id *nvme_nvm_id; > struct nvme_nvm_command c = {}; > int ret; > @@ -256,8 +257,8 @@ static int nvme_nvm_identity(struct request_queue *q, struct nvm_id *nvm_id) > if (!nvme_nvm_id) > return -ENOMEM; > > - ret = nvme_submit_sync_cmd(q, (struct nvme_command *)&c, nvme_nvm_id, > - sizeof(struct nvme_nvm_id)); > + ret = nvme_submit_sync_cmd(dev->admin_q, (struct nvme_command *)&c, > + nvme_nvm_id, sizeof(struct nvme_nvm_id)); > if (ret) { > ret = -EIO; > goto out; > @@ -299,8 +300,8 @@ static int nvme_nvm_get_l2p_tbl(struct request_queue *q, u64 slba, u32 nlb, > c.l2p.slba = cpu_to_le64(cmd_slba); > c.l2p.nlb = cpu_to_le32(cmd_nlb); > > - ret = nvme_submit_sync_cmd(q, (struct nvme_command *)&c, > - entries, len); > + ret = nvme_submit_sync_cmd(dev->admin_q, > + (struct nvme_command *)&c, entries, len); > if (ret) { > dev_err(dev->dev, "L2P table transfer failed (%d)\n", > ret); > @@ -343,8 +344,8 @@ static int nvme_nvm_get_bb_tbl(struct request_queue *q, int lunid, > > bitmap_zero(bb_bitmap, nr_blocks); > > - ret = nvme_submit_sync_cmd(q, (struct nvme_command *)&c, bb_bitmap, > - bb_bitmap_size); > + ret = nvme_submit_sync_cmd(dev->admin_q, (struct nvme_command *)&c, > + bb_bitmap, bb_bitmap_size); > if (ret) { > dev_err(dev->dev, "get bad block table failed (%d)\n", ret); > ret = -EIO; > Thanks Tao. I've added the bb set as well and a small fix to the l2p. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/