Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162623AbbKTN2B (ORCPT ); Fri, 20 Nov 2015 08:28:01 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:59721 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759811AbbKTN17 (ORCPT ); Fri, 20 Nov 2015 08:27:59 -0500 Date: Fri, 20 Nov 2015 07:27:56 -0600 From: Andy Gross To: Arnd Bergmann Cc: linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Bjorn Andersson , Kumar Gala , David Brown , linux-soc@vger.kernel.org Subject: Re: [PATCH v2] soc: qcom: enable smsm/smp2p modular build Message-ID: <20151120132756.GA20599@qualcomm.com> References: <4169906.YsYnNqcaru@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4169906.YsYnNqcaru@wuerfel> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1148 Lines: 27 On Fri, Nov 20, 2015 at 11:32:21AM +0100, Arnd Bergmann wrote: > The newly added smp2p and smsm drivers cannot be loadable modules > but depend on smem, which can be, and that causes a link error: > > drivers/built-in.o: In function `qcom_smp2p_intr': > :(.text+0xa6e68): undefined reference to `qcom_smem_get' > drivers/built-in.o: In function `qcom_smp2p_probe': > :(.text+0xa7320): undefined reference to `qcom_smem_alloc' > :(.text+0xa736c): undefined reference to `qcom_smem_get' > drivers/built-in.o: In function `qcom_smsm_probe': > :(.text+0xa7b34): undefined reference to `qcom_smem_get' > > This marks all the drivers as 'tristate' to make the Kconfig > dependency resolution work properly. Nice catch. I'll add this on top of those. -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/