Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1162838AbbKTOTE (ORCPT <rfc822;w@1wt.eu>);
	Fri, 20 Nov 2015 09:19:04 -0500
Received: from szxga03-in.huawei.com ([119.145.14.66]:11142 "EHLO
	szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1162812AbbKTOTA (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 20 Nov 2015 09:19:00 -0500
Message-ID: <564F2AED.30906@huawei.com>
Date: Fri, 20 Nov 2015 14:15:09 +0000
From: Salil Mehta <salil.mehta@huawei.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:31.0) Gecko/20100101 Thunderbird/31.1.2
MIME-Version: 1.0
To: David Miller <davem@davemloft.net>
CC: <robh+dt@kernel.org>, <pawel.moll@arm.com>, <mark.rutland@arm.com>,
        <paul.gortmaker@windriver.com>, <ijc+devicetree@hellion.org.uk>,
        <galak@codeaurora.org>, <catalin.marinas@arm.com>,
        <will.deacon@arm.com>, <arnd@arndb.de>, <liguozhu@hisilicon.com>,
        <yisen.zhuang@huawei.com>, <dingtianhong@huawei.com>,
        <zhangfei.gao@linaro.org>, <huangdaode@hisilicon.com>,
        <kenneth-lee-2012@foxmail.com>, <mehta.salil.lnk@gmail.com>,
        <xuwei5@hisilicon.com>, <lisheng011@huawei.com>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <netdev@vger.kernel.org>,
        <linuxarm@huawei.com>, <yankejian@huawei.com>, <lipeng321@huawei.com>,
        <fengguang.wu@intel.com>
Subject: Re: [PATCH V2 net-next 1/5] net:hns: Add support of Hip06 SoC to
 the Hislicon Network Subsystem
References: <1447786347-147518-1-git-send-email-salil.mehta@huawei.com>	<1447786347-147518-2-git-send-email-salil.mehta@huawei.com> <20151118.135250.2066223916643044258.davem@davemloft.net>
In-Reply-To: <20151118.135250.2066223916643044258.davem@davemloft.net>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.202.137.252]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
	refid=str=0001.0A020201.564F2B0F.0251,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
	ip=0.0.0.0,
	so=2013-05-26 15:14:31,
	dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: 05bcdb46c7603068edb4f5c10b9ad0ec
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 990
Lines: 29


On 11/18/2015 6:52 PM, David Miller wrote:
> From: Salil <salil.mehta@huawei.com>
> Date: Wed, 18 Nov 2015 02:52:23 +0800
>
>> @@ -387,19 +409,23 @@ static void hns_rcb_ring_get_cfg(struct hnae_queue *q, int ring_type)
>>   	struct rcb_common_cb *rcb_common;
>>   	struct ring_pair_cb *ring_pair_cb;
>>   	u32 buf_size;
>> -	u16 desc_num;
>> -	int irq_idx;
>> +	u16 desc_num, mdnum_ppkt;
>> +	int irq_idx, is_ver1;
> Please use "bool" and true/false for boolean conditions like is_ver1.
>
> Please audit your entire submission for this problem.
Thanks for your time and comments. As per your suggestions, I have 
changed the data type of variable "is_ver" to "bool" where ever possible 
in the PATCH V3 floated yesterday.

Best Regards
Salil


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/