Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162897AbbKTOYK (ORCPT ); Fri, 20 Nov 2015 09:24:10 -0500 Received: from foss.arm.com ([217.140.101.70]:46144 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161444AbbKTOYH (ORCPT ); Fri, 20 Nov 2015 09:24:07 -0500 Date: Fri, 20 Nov 2015 14:24:04 +0000 From: Liviu Dudau To: Russell King - ARM Linux Cc: LKML , DRI devel Subject: Re: [PATCH 0/3] drm/i2c: tda998x: Add support for atomic modesetting. Message-ID: <20151120142404.GI4158@e106497-lin.cambridge.arm.com> References: <1447256075-471-1-git-send-email-Liviu.Dudau@arm.com> <20151111175151.GI8644@n2100.arm.linux.org.uk> <20151111175718.GT963@e106497-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20151111175718.GT963@e106497-lin.cambridge.arm.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1488 Lines: 45 On Wed, Nov 11, 2015 at 05:57:18PM +0000, Liviu Dudau wrote: > On Wed, Nov 11, 2015 at 05:51:52PM +0000, Russell King - ARM Linux wrote: > > On Wed, Nov 11, 2015 at 03:34:32PM +0000, Liviu Dudau wrote: > > > While going through the code testing I've noticed an unbalanced > > > .unbind missing drm_connector_unregister() > > > > That actually doesn't matter, as DRM automatically tears them down anyway, > > so this isn't an urgent change. However, it's good practice to do so. > > It looks like it doesn't, or at least not if the error code is -EPROBE_DEFER. > On Juno, where the clocks are provided by SCPI and the load order is not > guaranteed, the first bind will fail with -EPROBE_DEFER but the sysfs entry > is not cleaned up, so on the next attempt the drm_connector_register() call > will fail. > > Best regards, > Liviu Gentle ping. Russell, are you happy with this patchset? If so, would you mind giving me your Acks? Many thanks, Liviu > > > > > -- > > FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up > > according to speedtest.net. > > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/