Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934917AbbKTOuD (ORCPT ); Fri, 20 Nov 2015 09:50:03 -0500 Received: from galahad.ideasonboard.com ([185.26.127.97]:34391 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751356AbbKTOt7 (ORCPT ); Fri, 20 Nov 2015 09:49:59 -0500 From: Laurent Pinchart To: Geert Uytterhoeven Cc: Geert Uytterhoeven , Greg Kroah-Hartman , Simon Horman , Magnus Damm , Yoshinori Sato , "linux-serial@vger.kernel.org" , Linux-sh list , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 00/25] serial: sh-sci: Add external clock and BRG Support Date: Fri, 20 Nov 2015 16:50:06 +0200 Message-ID: <3985193.nXz0F4qod7@avalon> User-Agent: KMail/4.14.8 (Linux/4.0.9-gentoo; KDE/4.14.8; x86_64; ; ) In-Reply-To: References: <1447958344-836-1-git-send-email-geert+renesas@glider.be> <11872773.MUvOKIUXMO@avalon> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1274 Lines: 35 Hi Geert, On Friday 20 November 2015 10:07:31 Geert Uytterhoeven wrote: > On Fri, Nov 20, 2015 at 9:58 AM, Laurent Pinchart wrote: > > On Friday 20 November 2015 09:22:16 Geert Uytterhoeven wrote: > >> On Thu, Nov 19, 2015 at 10:08 PM, Laurent Pinchart wrote: > >>> Could you briefly explain (and even better in a source code comment) > >>> how you handle baud rate calculation with the chained BRGs ? > >> > >> I'll do that. Note that there's no chaining of BRGs, only muxing (so yes, > >> it needs more clarification ;-). > > > > Really ? I thought the BRG-EC was one possible input for the internal BRG > > ? Does it bypass the internal BRG ? Or do you configure the internal BRG > > to not divide the clock when using the BRG-EC ? > > Yes, it's bypassed. > > Cfr. SCSCR.CKE[1:0]. > '00' means internal BRG (although the docs state P divided by 1/4/16/64), > '10' means SCK or SC_CLK (SCIF_CLK/INT_CLK). That's indeed simpler. Could you capture the behaviour in a source code comment ? -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/