Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760285AbbKTOxF (ORCPT ); Fri, 20 Nov 2015 09:53:05 -0500 Received: from galahad.ideasonboard.com ([185.26.127.97]:34406 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751356AbbKTOxC (ORCPT ); Fri, 20 Nov 2015 09:53:02 -0500 From: Laurent Pinchart To: Magnus Damm Cc: SH-Linux , Linus Walleij , linux-kernel , Koji Matsuoka , linux-gpio , "Simon Horman [Horms]" , geert@glider.be Subject: Re: [PATCH 00/04] pinctrl: sh-pfc: r8a7794: DU support Date: Fri, 20 Nov 2015 16:53:10 +0200 Message-ID: <7175557.3oSik5Zhyq@avalon> User-Agent: KMail/4.14.8 (Linux/4.0.9-gentoo; KDE/4.14.8; x86_64; ; ) In-Reply-To: References: <20151117031832.24924.60685.sendpatchset@little-apple> <2997631.z1xUhmAZzM@avalon> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2234 Lines: 56 Hi Magnus, On Friday 20 November 2015 16:16:15 Magnus Damm wrote: > On Fri, Nov 20, 2015 at 11:46 AM, Laurent Pinchart wrote: > > On Tuesday 17 November 2015 12:18:32 Magnus Damm wrote: > >> pinctrl: sh-pfc: r8a7794: DU support > >> > >> [PATCH 01/04] pinctrl: sh-pfc: r8a7794: Add DU pin groups > >> [PATCH 02/04] pinctrl: sh-pfc: r8a7794: Separate DU CDE and DISP > >> [PATCH 03/04] pinctrl: sh-pfc: r8a7794: Add missing dot clock signals > >> [PATCH 04/04] pinctrl: sh-pfc: r8a7794: Break out ODDF from sync > >> > >> These patches take the r8a7794 PFC DU support code from the BSP > >> and reworks it to fit the r8a7794 ALT board. Tested with the ALT > >> VGA port - by default PFC is not used however enabling PFC using > >> an incremental (yet to be posted) patch works well. > >> > >> It is worth noting that patch 2-4 modifies the pin groups. This > >> means that the upstream DT ABI for PFC DU will differ compared > >> to the unreviewed BSP code. > >> > >> In general it is not considered good practice to change the pin > >> groups and break compatibility since they are part of the DT ABI. > >> > >> For this particular case upstream never have had PFC DU support > >> for r8a7794, so treating the BSP bindings as experimental and > >> migrate away seems reasonable. > > > > If we start considering DT bindings that never went upstream as stable > > we'll have a big problem. I mean even bigger than the upstream DT > > bindings stability problem :-) > > I'm not saying that local DT hacks should be considered stable, more > that it as usual makes sense to follow upstream first with proper DT > review process early on. > > >> Signed-off-by: Magnus Damm > > > > Wouldn't it make sense to merge the 4 patches together ? > > Yeah, I guess so. My feeling is also that it would be good to verify > HDMI on ALT before commiting to DT bindings. Right now only one DU > channel is tested. I agree with that. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/