Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1163035AbbKTPPr (ORCPT ); Fri, 20 Nov 2015 10:15:47 -0500 Received: from mail-by2on0056.outbound.protection.outlook.com ([207.46.100.56]:5077 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1162859AbbKTPPm (ORCPT ); Fri, 20 Nov 2015 10:15:42 -0500 Authentication-Results: spf=fail (sender IP is 66.35.236.227) smtp.mailfrom=opensource.altera.com; lwn.net; dkim=none (message not signed) header.d=none;lwn.net; dmarc=none action=none header.from=opensource.altera.com; Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=atull@opensource.altera.com; Date: Fri, 20 Nov 2015 09:08:16 -0600 From: atull X-X-Sender: atull@linuxheads99 To: Moritz Fischer CC: Rob Herring , Josh Cartwright , Greg KH , Michal Simek , Michal Simek , Pawel Moll , Mark Rutland , Ian Campbell , "Kumar Gala" , Jonathan Corbet , , , , Pantelis Antoniou , Alan Tull , "dinguyen@opensource.altera.com" Subject: Re: [PATCH v13 4/6] fpga: add fpga bridge framework In-Reply-To: Message-ID: References: <1446570664-10293-1-git-send-email-atull@opensource.altera.com> <1446570664-10293-5-git-send-email-atull@opensource.altera.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [64.129.157.38] X-ClientProxiedBy: CY1PR12CA0054.namprd12.prod.outlook.com (25.163.230.22) To BLUPR03MB1506.namprd03.prod.outlook.com (25.163.81.24) X-Microsoft-Exchange-Diagnostics-untrusted: 1;BLUPR03MB1506;2:/HTVq0u9/MoDKe0ruBeHGrvCy7tcL8s5xdPDwovWZdzkrCV8wD0hR6V+VXbe0PAqa1hRWAl4cCIOedEWb7MhwsNFBrLieWfo5G9WsrneAWfW3Iudu0X+VbjGarkFoD4TzZnVgdDFOzGAnK8hK71YhA==;3:cJlUgnd6KjdJQ//LHBbDvNeKeODZq7aARe3DZ2YpQLEKC0e+ZLrPdXvLLbj10zT/Qe+GhThGmFtunhy3qe3WpC5gU/ld+eq5nOocqn3YqpQ0RrTyhtpJ6HCCVtncmh+z;25:iYDM5ebiRGvcGDXpXacz4M8HbJbZDGy8pAiE0OdCaTFj/e4TBalOjTasDkNW1mB59aLhzrQ7n9OYRm6awHug0cS8P3d6tC5Rl0FDimPf62gtYHi0tj2AqCOHEHprVC7wP7PN2Clk1LjxAOpfeulG8C0xYvMwHpWWYn0SPunAyadUho7AnvIHOGuC06SD/KUtLJdcC8wZPLay0ahTzCJ+wdzfMewDq3aozeeA5A+nOYSFaGXUsoJ7q+xq3Ak5IPL4ddmhbokcgHR5m2nfsfGf8A==;20:Q1tQ1VH+u2n5n9b85/pcVw5/sw1U9bnPNzqzu/pE0h+Ck7V/KJgedNLgZnH2UmiOgAtQnvtbwx+zpAT+/UcPyx/97oJCoaLwFGFpsnsozmoGfYsp16B3fXMHiyGWVSAEwL+x5fbbkA9Ar9YTtZrVEuSgLk1WbJ7IiUWT/qKxYhc= X-Microsoft-Antispam-Untrusted: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1506; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(80048183373757)(204874498639787);UriScan:(80048183373757)(204874498639787); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(5005006)(8121501046)(10201501046)(3002001);SRVR:BLUPR03MB1506;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1506;BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(520078)(5005006)(10201501046)(3002001);SRVR:SN1PR0301MB1662;BCL:0;PCL:0;RULEID:;SRVR:SN1PR0301MB1662; X-Microsoft-Exchange-Diagnostics-untrusted: 1;BLUPR03MB1506;4:/qpJ4/RrxstaqNDsHbD/vZoRQvAnl8DX9TQeBuQI5BwkfDSisxo1960mg7fVnbiij0nlK4LpzwymehwZPNNF6BDgCC2NDpgC/i4EtVZQi9cB1r6BFOM7Qtr0ggQfxj1t+Odgj0T6aNo10EJLkgJplGrERGjAgleLJved0ZMnC5QGbxe3oBN7jPF/R+sZQRSDDnaPQ2RdVZJUlibe7/XxyB+1JZQz6dEr6ZCTe7kmSN7sqQf/Sq0Z/U0i2/aNI5NsaNWXQLFV+XMtido4yMstXGzG8t4MwbUDBaFVkCYjx7UMqjNa0b1gqCbz13oMv1hzGDS/2MmOy0TgtjCXedCBcf+u+s+pHoWtEmIPiuzLaGrprh/HwwYHKl5QWS649NVCCuHxhAOANKyZBDDedKOphMoQLnNmqkT8/dLelairhWFg+CDye8fU04IBBUUMANoU/dz/crCDy53+vOTa4N/38w== X-Forefront-PRVS: 07665BE9D1 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(6009001)(199003)(24454002)(377454003)(189002)(46406003)(101416001)(83506001)(40100003)(92566002)(33716001)(50466002)(122386002)(5007970100001)(5004730100002)(6116002)(3846002)(4001430100002)(5008740100001)(53416004)(97736004)(586003)(2950100001)(81156007)(76176999)(19580395003)(19580405001)(87976001)(54356999)(77096005)(50986999)(42186005)(86152002)(5001960100002)(4001350100001)(86362001)(106356001)(47776003)(105586002)(107886002)(110136002)(189998001)(66066001)(69596002)(23726003)(7059030);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR03MB1506;H:linuxheads99.altera.com;FPR:;SPF:None;PTR:InfoNoRecords;A:0;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics-untrusted: =?us-ascii?Q?1;BLUPR03MB1506;23:z9x+KSgYFgYNVfdh45gUj0IGDTe8Kw4NyQ+CcT66A?= =?us-ascii?Q?N+ey2KbGrUYL3IkT8jZK8VYKF6vcV7xZtNEEEw+TNRMNBnkQBgdSAqYPtov9?= =?us-ascii?Q?55NF01Pl4yNL1dg0al4C59/sNocCDwtEXRPuNueZh+mRPw7CB2iMM/BS7zog?= =?us-ascii?Q?oxNhfPhe61ea7h4i/i64pmLi8MUZ/b02gI7kHOOd9Nb/IRdoyUHLR87889Kp?= =?us-ascii?Q?sNqgUvx5xJozaGD5L1fz9cIUyqYS+v+DO972mkfSlXTHPpCBiQ0E7cEZ+JD2?= =?us-ascii?Q?GIsidwz4ADFoj53ZAv8Gugr1azCaCbkCHSDFJqaStITOYFbX+w9mFu71McJ1?= =?us-ascii?Q?vL+iG1q1yTVQzunhdAx3unGtx4wb2jF9xc0nu9mQa1751fYpz1s//q3nv9F5?= =?us-ascii?Q?dr/utycVpbFrkIvONSXUA41uonqT0fYg279bK2XUUm6MhNts/5SapjAEHYeF?= =?us-ascii?Q?HebFOHSfWBnEOMyOQnx7bvG4gJWd1R5EtvmZLfUzUL0vhVjfez8xG2bAOyI1?= =?us-ascii?Q?HohR/vAJDsQjgZ3OzidTqOiqF0H0NWgdBtzS3qwM6k1f/6P/O2VQo3WQNf8B?= =?us-ascii?Q?IbMNEpj/dAIZHm0WfUHCL2qJHEXmE/seW+qrludDX8tGWDJVUMxTSoskxztX?= =?us-ascii?Q?huW1EZ7RIn6xsGQJCWryfNrLS6sXMrfHNSW7/wGS6xQlKldV9cJoGvLr/7bd?= =?us-ascii?Q?N8i/M3LUNgPIWzpu9Twnh8CHESR9jqKBMwLkNKxosqHuqvakGYPoHcG63vwP?= =?us-ascii?Q?ReqhEzSbaK6DpGOHINLapH+AgZryzpJnjB2rOCYrG2RBafz4yOgKVljiSnor?= =?us-ascii?Q?GInMmBWgF9DLWOLSyYEsSe+6yfGzDRwEt318XkmEVhuywLcAnoSGbfBOgDqh?= =?us-ascii?Q?rItdxuxT+AD3ypZZJd6M8Z6xM30upTzLYDQRr6Minxf/pnbCU21BnU+xAOyK?= =?us-ascii?Q?TlNuuqVXp1fx0ni7/JPKGv2HPy7m6pcS2AOl5Vp69Lp65cI02oOeQTqNRTzB?= =?us-ascii?Q?sbYfdOhMQJ18DnDFo1km+Pt+GXJ83UcnPI+M3JYFTcf7xP+3woxEYPdYrc4G?= =?us-ascii?Q?QLSGESoMNQmwbW5y2VoxMS4Ttt8w7cn7ymIPAC081hyGgm/werSD5poxpv58?= =?us-ascii?Q?1ZzNtG1+kLuDilqrBP8GgOoZ1Esy4IP2A/P3wuvAdgTuhpapMFswxZTh2EkY?= =?us-ascii?Q?QphV6LmG+RcWbap8rOuFBcNCRmH+9v74zQHWc4IAWvFh3NsmOW0RkyNGA=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics-untrusted: 1;BLUPR03MB1506;5:JIQVoxr5wzXBmCMN+myJfbsuvNWCosGs2n31Gnlfs7ILSiR90tTrwc5hxcm82S9fQJKQmDkKAkp6PndcLAcfq1Yk4CSxrxSC1XtknctQhFmfHphugaPk87fD77oKNGlOKA7LF2893/f0DM9tkYz9iw==;24:K5mrHJaiFOLkUvWRygUWrckwQZdoBgVDYtqMzJMvycEY9Gg49eZp35JJXQhS5tHNTreveXx47ZNp2UoWpZR4MWHaq2XsQ68FAZ6ULVmiQrM=;20:XY9v2MIJLlLLYL4E9EpRfgQ5P9YAOjLXEpW2A49/obNXjr/AFdX30Q8pyKwA34sEck7I4JwfiYmAfzIKJZEHVzYXt9LOLqRTQ5mLE2hctcuFJPTUMPwhTH+f1tE7mD+RnIvXVciCD1AugXoJkAW4giru99PBZILMvOMZyQyjgfs= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB1506 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: BY2FFO11FD043.protection.gbl X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD043;1:UDUe5WVzE2CuijqIvq+iWW7ViwljEWViu63A5yFO0UcEUDQ3SGy8FphqqQSM0+GZN+oowg4VBl+sbtg3MgPjqY+YB5DVzlJGtXjSbsJ5CyXLGdTGTo4URAzJYBRqgQiAH9XpSG5ORb0dJ7EtgqHAOqu/pDLmyumVwUp50oA+NxOgua4ngyLkcKWbVpJcXyxhYDIVPmywu0iHYIRcIiR6T0XaDdwU5y3QpQUzRTSRPBN64ga4xPl8BxlG1H5Wtb1AwvNM8LRQZ/HZhTey0auyxB2E1QPWiXaf23OTuCb7OQXbFwmv/B8vS6GLgArTsQnyK4maECvbjkn6OP7w5MVv2CruWXyO8h7FKidxKGozcpWMb1GKQ04hQ1CSpxuiJz14XZ5gVuEAVb1DYFSv9izMQTSCWO0wwV5b6KXLiO8CLzk= X-Forefront-Antispam-Report: CIP:66.35.236.227;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(1110001)(1109001)(339900001)(189002)(377454003)(24454002)(199003)(105606002)(5007970100001)(33716001)(4001350100001)(6070500001)(77096005)(81156007)(47776003)(5004730100002)(4001430100002)(5008740100001)(92566002)(6806005)(40100003)(2950100001)(66066001)(6116002)(110136002)(23726003)(21840400001)(3846002)(107886002)(16796002)(97736004)(189998001)(122386002)(87936001)(5001960100002)(86362001)(86152002)(76176999)(19580395003)(586003)(19580405001)(54356999)(50986999)(46406003)(85426001)(53416004)(106466001)(11100500001)(83506001)(50466002)(7099028)(7059030);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR0301MB1662;H:sj-itexedge03.altera.priv.altera.com;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;MX:1;A:0;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;SN1PR0301MB1662;2:eCDzBHh6VU1DHzb8PojyFFvxpqyf+FMb6114qzW99pjzVIgIqKn7RQ3fXbNt+SzenUGCOzBclIdp+sswuqSr6KD9KndoN7gEtYiGwR8yPH3LP6LEd2cwvbGgmrddcgDJJfIaHmDBZdw+5FYc1U2oZ1w4EWytU298f5R9S3hRckI=;3:9bf7g9XFQFPBp966aUzDCQu4zhJoGVPymTQOGTSdkC9faZoadFyWETBM1XUNivqmSgrlFymE87fBnSXRpikp7mjoN6dDuVajt88+jUyfRIzLdoUXyJRbZPQyaueFG2wSc5Ofepe+m61yLyFP9HMSOvrGtP4qvds+Ps0g4Lnq5U4jpP/3YLEx1jXetwFAUJPmR9XANSDAH960Lntf7J41z0oJBdfpndB6xyxbx6qts2E=;25:9T6i2+lETwqDF9qtOcxEfDHx9ECAsAJl3USnp9jV+RE7bzB/TsuF+aMhNM7bku6+ygdfGAJYBH+kr05APn+zLm3+11KMW+qsUsHPj6L0vElqKr0xMEO62QxSpcmWm0zB/MJiUiX5lj4uORMx4rMZ+Arvg/dIW06gD2hSK0NUVYzBuMTOibLni3oq2IEUIyQC06EL25R4MHLJmXoXtgCIq43rgdjV+gZ+Y+cq6Ejzv607KuUctF14pHYInJnU32AadS7brsezzP6JV+XL0Zum4Q==;20:AHMrrjWaE6YKXl4bKfgj3DchcJEeXZ/udI2gJs7LAaYFm7is6Aa6an0yG5qhSFsDA8sQe0LiOED/ItzxuG6h8Xvil8s7wc9cDRol9ddY4qR8iFuh44qqVRsJylk0rcm7ox1fMDJ4ZlfZ2T8q4ko3DbrXxnPV+4sqKzWjZnFPWFk= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR0301MB1662; X-Microsoft-Exchange-Diagnostics: 1;SN1PR0301MB1662;4:zpFGekCYZ+IZfw7GXWaUK1zw7Ya/u8b7HsHGt2juJqgaxAPiAZXPdpKOJNBymc6C0JaejO49RgC4uyH7B6dwG3+eNFnV4Jc833Et2xsrTPu80Tw4br/jvPkiYyn9h1o+oOxcuw6tEnyI7u/fR0nt64g8kK3u2L81ZFSxjg/r5fSmQaFS2rGNqql9VWSLTQpi7noAczH0WTOCqzg0B0lserlGebDpKf4oEamErkwJYX5PvO/3LmmN3avrZ2rCJ2giA11OlWa8jvoeSg1NJWl3bRqbcyLg6q7kFqMcBIsqeak409rATY8olnp4TLWduFdzeNpkUSvcbBPL0u/95sZZay1FQFwHuY3/kCNvfKyhKflGnsDiYRQnaxmeSaM47TRIKUumA8ncw7tHNwJQ4ue8xw== X-Forefront-PRVS: 07665BE9D1 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;SN1PR0301MB1662;23:6biGSP8vlU/zp/It+7lraqtJZCIeFqDSAIxFZwJ?= =?us-ascii?Q?qhlL8KTGedFksb+8NVC1sGJsS4HaatSbk0BEo0gxJknB0+fKatQ34t6jt1wU?= =?us-ascii?Q?OZfWnqojircJoC90vBiGgrRKSfk48FugRiezx7j14joXwIEbtMLkoumYFGgk?= =?us-ascii?Q?NfxP+0E0zQ6a0nwCrqb801Oh5xtB0qqeJ/OprZ+tFM2mTJ4/lL73jpSEVtoN?= =?us-ascii?Q?5Q6XBcM0LbIiNEEtP1JLzS3yCLXnZ7+2hG/XmJijpQxReneWY5jkiu1cKoys?= =?us-ascii?Q?6JPohoFEzPa8k2oKS5H1AjtkhYNRUp+UO7tPeeKwhOW7i/6EEV029HPaXB5D?= =?us-ascii?Q?1qcQavoA0Ugt5+/Q3hbNPgZeSxW4Kh3022DfUCuovSIDO2M448i8eTbnQL5t?= =?us-ascii?Q?UtkqNwZyZArm1VpkghTWuYfR8R+6GZypJwxlwzQHa6JxsisVL2juIFLojJfN?= =?us-ascii?Q?RbC+739dFnNGO6zAknZwBn9SZnTlPdJR9hNONtHgBfu3GRC57hIVSi/1ub+o?= =?us-ascii?Q?knXfzf+b+Clba7yYaGpoyXMD+ilqimdojYTj2fLt4bbJtdGgHlIeQCntZMqL?= =?us-ascii?Q?DnPOD3Wt1RsdSeBCpD/DurmyoDsqKeBLkZ8BqruY6eLcx9yHvy8fsZUC166C?= =?us-ascii?Q?r8fzuj/fJF0iUF11BgcjfrZLaLSvm3jo2X+Nfw/6o35HIjD8RqXEKHh0y516?= =?us-ascii?Q?63PDH04yWLQ/yb/54778JBkgxnXFhcN6BEddaD/bAZsph0bt70JqXHHQo42o?= =?us-ascii?Q?AAF7I488Ni90y5FlGKKRj0Jf2vr5OMyfMk5eteBL3J+R3av/ozbe6BM4ihal?= =?us-ascii?Q?5MXePMAiJPU4l7+yaGd8+OyapXXojiVZ9N25wRBXtzIzTWcHBKcfcqqRJyCx?= =?us-ascii?Q?WuqSlzv8neKf+MEjYyu1tS3wwCI/flYDljEfVf6cNewd5+gcJ1FlWaWp0985?= =?us-ascii?Q?Cyyt93bIqDF/qfBuI4H/YmYvSNy3eBudKnzOiLgiJp6asBmxAd42l+h2x6Wz?= =?us-ascii?Q?UFgUH5nmyErTMdRhXMQhyNouFIX4R8geeb3u/NTkAIpw44sDROp2FNkzt3V8?= =?us-ascii?Q?fiM5m40/9GtJmBR4BElNdN0TIMAK7t78eSdJPb24RxcuW6goPSx5p8+yb5y3?= =?us-ascii?Q?ZXw6fHd5+l2jO9LeaqQllJ42Q0+IYqVP4rl15eshFVLV2erVO+L2cAUVFGQ/?= =?us-ascii?Q?Si/MTOjrWo8RKwRH3rwlScU+g7b5muS2KfzFhoPRKXIgWkLDOo3WEp+Uhav3?= =?us-ascii?Q?gDh/sfMUjS+1dL5sVIi50roSd959L667QuxA2A3FPADMUpCZiZUlEzmiDpiC?= =?us-ascii?Q?GIqlU/k2GgHlhRMlNrAsn2d5ltHccM19RggsOdxiQ29Ylj9xACcozPEnLGHJ?= =?us-ascii?Q?RgxtrGB0FgHCrTmqhwkW5/BhQqZS1KyVfPieMwsnEpWWods7k?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR0301MB1662;5:y5sYm6FNTt/VC0BPL/FVaslbcD8kZ9/Y7iacGpMN8vJ7gT5OTBehlHRXTo4eMaunfInhnb4eZWFbHM4MakEBCruRtWnCfWUwtCTbW6SPa7ww3ACQHeeOUPDfLtSGJfAXovQTa7rvL70x6XEOl29LoQ==;24:3FNvNVBTTW8VsQDU+lzsM3pd0M7cKkA4S6OdC45zv4jcTL6Jemsw398AjAg0iVJwnNsu3QVcpGEFrARrtLmue6K4KT+xQzPchjjsumTPslE=;20:pakqqr1EfsIZidCg793WBJ1bq3QTryvpsGXRZM89i0n+DBu+N/i5FQIKC55vrHn57dqoPxtFrbDK9w1/tfBVnxFcCbUC22cwTKDfEHn3LEuFI9L1Y7Z3vzG703J7D+R+p0OF5gdpLhrNXavzbdAJwanF5eQaoGa75boIwZ3DwSo= X-OriginatorOrg: opensource.altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2015 15:15:38.7726 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.227];Helo=[sj-itexedge03.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0301MB1662 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 969 Lines: 35 On Thu, 19 Nov 2015, Moritz Fischer wrote: > Hi Alan, > > while trying to implement something that works for Zynq along these lines > I stumbled upon some minor stuff. > > On Tue, Nov 3, 2015 at 9:11 AM, wrote: > > > + * Return: 0 on success, negative error code otherwise. > > + */ > > +int fpga_bridge_register(struct device *dev, const char *name, > > + struct fpga_bridge_ops *br_ops, void *priv) > > const struct fpga_bridge_ops > > > +int fpga_bridge_register(struct device *dev, const char *name, > > + struct fpga_bridge_ops *br_ops, void *priv); > const struct fpga_bridge_ops > > Cheers, > > Moritz > Hi Moritz, Thanks! Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/