Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760571AbbKTPKn (ORCPT ); Fri, 20 Nov 2015 10:10:43 -0500 Received: from hqemgate15.nvidia.com ([216.228.121.64]:14693 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760522AbbKTPKl (ORCPT ); Fri, 20 Nov 2015 10:10:41 -0500 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Fri, 20 Nov 2015 06:58:43 -0800 Date: Fri, 20 Nov 2015 16:10:32 +0100 From: Thierry Reding To: Arnd Bergmann CC: Rhyland Klein , Peter De Schrijver , Prashant Gaikwad , Michael Turquette , Stephen Boyd , , Stephen Warren , Alexandre Courbot , , , Subject: Re: [PATCH] clk: tegra: move _calc_dynamic_ram_rate out of #ifdef Message-ID: <20151120151031.GD3300@ulmo.nvidia.com> References: <4290741.p1jMzEOUEU@wuerfel> MIME-Version: 1.0 In-Reply-To: <4290741.p1jMzEOUEU@wuerfel> X-NVConfidentiality: public User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) X-Originating-IP: [10.2.70.146] X-ClientProxiedBy: UKMAIL102.nvidia.com (10.26.138.15) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xXmbgvnjoT4axfJE" Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2379 Lines: 59 --xXmbgvnjoT4axfJE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 19, 2015 at 11:32:33PM +0100, Arnd Bergmann wrote: > _calc_dynamic_ram_rate is defined inside an #ifdef but called > later in the same file outside of that #ifdef, which can cause a > build error: >=20 > drivers/clk/tegra/clk-pll.c: In function '_tegra_clk_register_pll': > drivers/clk/tegra/clk-pll.c:1541:29: error: '_calc_dynamic_ramp_rate' und= eclared (first use in this function) >=20 > This moves both _calc_dynamic_ram_rate and _pll_fixed_mdiv in > front of the #ifdef to make all configurations compile again. >=20 > Signed-off-by: Arnd Bergmann > Fixes: 44c8b9fa432c ("clk: tegra: pll: Fix _pll_ramp_calc_pll logic and _= calc_dynamic_ramp_rate") > ---- > The patch that caused it appears to be older, but I only ran into > the randconfig bug today for the first time. Apparently the commit > is only in linux-next at the moment, not in 4.4-rc1 Hmm... this looks familiar, I thought I had included an equivalent patch in the clock tree. I'll go do some digging, but this looks exactly like what I had done at the time. Thanks, Thierry --xXmbgvnjoT4axfJE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJWTzfmAAoJEN0jrNd/PrOhxC0QAL0mKUm99890XJQWumHt3akC e7nPpyPLhi9s89HzoPd1y1BwI9lT2mY/09OAxeAsgM//7blAucf+9+HSLmPe7JJc puLZYDXy6QAgmqqPODFahJcemU6PfRcU+JDM5+73Ym6lc71v3KEsFKtqWhy+FT+a XO02Vw9IL8w5pN1QtZ2jG0l4T8Rj2V66WreGl4+4/of6F/IL+p/MrIV7tNdaFDdi brWKGLBh21ihHjmhd/5W2UkpSlg+lbl5O7JJlCeneHfSVHXhYXvXiK1zziUeMSo+ P6BASGqY+K88s0i+dQt+VOUpgUJP+swFY60eH3ynjc69/+QMRdafyKUsRtIDvryY Smr8YRXGypmHfyDPdZJEgnineGscfy2Yxl/AHub5/QNaa7OJE/Rj2vTBq+e+j7SP RAO/UAcNDQ1R7k3jb1/lz62s7GBAmt5MJJ+Q9WXWgxF8wxHOayD7D7dlMquWvCzP YOsVwymMb5CRcs2DxuSsFVPojtc4bVYiXopMg1DfL+uCKFx+qEM7EeyoIDKHfKvd l1SQ+5T4EOKx5NnmmEN9aXXBIJS9taep2Yyr2AUv/yerSgAByOplwki0JiKzpRky GGhL6wmkzSpmxgwmQYxFn9nKYgd8DuciJOh47qpQ8w6tFL/Ub08kFemow2dnF93B 8O1rQ4OGzgFRf48nDnDx =K6N1 -----END PGP SIGNATURE----- --xXmbgvnjoT4axfJE-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/