Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1163095AbbKTPa1 (ORCPT ); Fri, 20 Nov 2015 10:30:27 -0500 Received: from mail-wm0-f46.google.com ([74.125.82.46]:38206 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1162962AbbKTPaX (ORCPT ); Fri, 20 Nov 2015 10:30:23 -0500 MIME-Version: 1.0 In-Reply-To: <2770504.I7SM1dx10G@avalon> References: <1447958344-836-1-git-send-email-geert+renesas@glider.be> <1764695.P2DCFfYC1V@avalon> <2770504.I7SM1dx10G@avalon> Date: Fri, 20 Nov 2015 16:30:22 +0100 X-Google-Sender-Auth: RYtRJFLNBkEjEF9G7mf75J-UaAA Message-ID: Subject: Re: [PATCH 17/25] serial: sh-sci: Correct SCIF type on R-Car for BRG From: Geert Uytterhoeven To: Laurent Pinchart Cc: Geert Uytterhoeven , Greg Kroah-Hartman , Simon Horman , Magnus Damm , Yoshinori Sato , Laurent Pinchart , "linux-serial@vger.kernel.org" , Linux-sh list , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2121 Lines: 48 Hi Laurent, On Fri, Nov 20, 2015 at 3:52 PM, Laurent Pinchart wrote: > On Friday 20 November 2015 08:46:56 Geert Uytterhoeven wrote: >> On Thu, Nov 19, 2015 at 9:55 PM, Laurent Pinchart wrote: >> > On Thursday 19 November 2015 19:38:56 Geert Uytterhoeven wrote: >> >> The "renesas,scif" compatible value is currently used for the SCIF >> >> variant in all Renesas SoCs of the R-Car family. However, the variant >> >> used in the R-Car family is not the common "SH-4(A)" variant, but a >> >> derivative with added "Baud Rate Generator for External Clock" (BRG), >> >> which is also present in sh7734. >> > >> > Time to introduce a "renesas,scif-rcar" compatible string ? ;-) >> > >> > As the only DT-enabled platform to have a different SCIF type is r7s72100 >> > we could also consider just switching the regtype to >> > SCIx_SH4_SCIF_BRG_REGTYPE for the generic "renesas,scif" entry as it's >> > listed after the "renesas,scif- r7s72100" entry. That might cause an >> > issue if we want to enable DT on arch/sh though, but even if that happens >> > due to the J-Core processors I'd be surprised to see the old Renesas SH >> > platforms being moved to DT. >> >> I thought about that, but you never know in which out-of-tree BSP it ended >> up being used, too. So better safe than sorry. > > Out-of-tree should be banned :-) > > More seriously, I suppose you wouldn't be thrilled by the idea of a > "renesas,scif-rcar-gen2" ? Nope. Note that it's also used in R-Car Gen 1 and Gen 3, and sh7734. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/