Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1163140AbbKTPbL (ORCPT ); Fri, 20 Nov 2015 10:31:11 -0500 Received: from mail-wm0-f45.google.com ([74.125.82.45]:37175 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759525AbbKTPbH (ORCPT ); Fri, 20 Nov 2015 10:31:07 -0500 MIME-Version: 1.0 In-Reply-To: <3985193.nXz0F4qod7@avalon> References: <1447958344-836-1-git-send-email-geert+renesas@glider.be> <11872773.MUvOKIUXMO@avalon> <3985193.nXz0F4qod7@avalon> Date: Fri, 20 Nov 2015 16:31:05 +0100 X-Google-Sender-Auth: UmP17Eq1bNvz80hcpdu4z_D9HpI Message-ID: Subject: Re: [PATCH 00/25] serial: sh-sci: Add external clock and BRG Support From: Geert Uytterhoeven To: Laurent Pinchart Cc: Geert Uytterhoeven , Greg Kroah-Hartman , Simon Horman , Magnus Damm , Yoshinori Sato , "linux-serial@vger.kernel.org" , Linux-sh list , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1693 Lines: 42 On Fri, Nov 20, 2015 at 3:50 PM, Laurent Pinchart wrote: > On Friday 20 November 2015 10:07:31 Geert Uytterhoeven wrote: >> On Fri, Nov 20, 2015 at 9:58 AM, Laurent Pinchart wrote: >> > On Friday 20 November 2015 09:22:16 Geert Uytterhoeven wrote: >> >> On Thu, Nov 19, 2015 at 10:08 PM, Laurent Pinchart wrote: >> >>> Could you briefly explain (and even better in a source code comment) >> >>> how you handle baud rate calculation with the chained BRGs ? >> >> >> >> I'll do that. Note that there's no chaining of BRGs, only muxing (so yes, >> >> it needs more clarification ;-). >> > >> > Really ? I thought the BRG-EC was one possible input for the internal BRG >> > ? Does it bypass the internal BRG ? Or do you configure the internal BRG >> > to not divide the clock when using the BRG-EC ? >> >> Yes, it's bypassed. >> >> Cfr. SCSCR.CKE[1:0]. >> '00' means internal BRG (although the docs state P divided by 1/4/16/64), >> '10' means SCK or SC_CLK (SCIF_CLK/INT_CLK). > > That's indeed simpler. Could you capture the behaviour in a source code > comment ? Sure. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/