Subject: Re: [PATCH V3 00/10] KVM: x86: MMU: Clean up x86's mmu code for
 future work
To: Takuya Yoshikawa <yoshikawa_takuya_b1@lab.ntt.co.jp>
References: <20151120174005.9880b89f54eee2cec2422da5@lab.ntt.co.jp>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, mtosatti@redhat.com,
        guangrong.xiao@linux.intel.com
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <564F43CE.701@redhat.com>
Date: Fri, 20 Nov 2015 17:01:18 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <20151120174005.9880b89f54eee2cec2422da5@lab.ntt.co.jp>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 971
Lines: 25


On 20/11/2015 09:40, Takuya Yoshikawa wrote:
>   About patch 03: There was a comment on the usage of braces for a single line
>   else-if statement from Xiao. As I answered, checkpatch did not complain about
>   this, and when the corresponding if block has multiple lines, some developers
>   prefer/recommend this style. Feel free to modify it if you don't like it.

I wonder if we can remove the "else if" completely.  Will take a look
after applying, early next week.

> For these three, I'm not sure what we should do now, still RFC?
> We can also consider other approaches, e.g. moving link_shadow_page() in the
> kvm_get_mmu_page() as Paolo suggested before.

I think I will include them in kvm/next.

Thanks,

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/