Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760739AbbKTQ1Q (ORCPT ); Fri, 20 Nov 2015 11:27:16 -0500 Received: from unicorn.mansr.com ([81.2.72.234]:55162 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759269AbbKTQ1P convert rfc822-to-8bit (ORCPT ); Fri, 20 Nov 2015 11:27:15 -0500 From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Rob Herring Cc: Thomas Gleixner , Jason Cooper , Marc Zyngier , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 1/2] devicetree: add binding for Sigma Designs SMP86xx interrupt controller References: <1447958026-3015-1-git-send-email-mans@mansr.com> <1447958026-3015-2-git-send-email-mans@mansr.com> <20151120162304.GA28663@rob-hp-laptop> Date: Fri, 20 Nov 2015 16:27:04 +0000 In-Reply-To: <20151120162304.GA28663@rob-hp-laptop> (Rob Herring's message of "Fri, 20 Nov 2015 10:23:04 -0600") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1782 Lines: 44 Rob Herring writes: > On Thu, Nov 19, 2015 at 06:33:45PM +0000, Mans Rullgard wrote: >> This adds a binding for the secondary interrupt controller in >> Sigma Designs SMP86xx and SMP87xx chips. >> >> Signed-off-by: Mans Rullgard >> --- >> .../interrupt-controller/sigma,smp8642-intc.txt | 47 ++++++++++++++++++++++ >> 1 file changed, 47 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/interrupt-controller/sigma,smp8642-intc.txt >> >> diff --git a/Documentation/devicetree/bindings/interrupt-controller/sigma,smp8642-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/sigma,smp8642-intc.txt >> new file mode 100644 >> index 0000000..f82cddf >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/interrupt-controller/sigma,smp8642-intc.txt >> @@ -0,0 +1,47 @@ >> +Sigma Designs SMP86xx/SMP87xx secondary interrupt controller >> + >> +Required properties: >> +- compatible: should be "sigma,smp8642-intc" >> +- reg: physical address of MMIO region >> +- interrupt-parent: phandle of parent interrupt controller >> +- interrupt-controller: boolean >> + >> +One child node per control block with properties: >> +- sigma,reg-offset: offset of registers from main base address > > Your driver defines these offsets too. > > Do you expect to have many different variations here? If not, I would > get rid of all the child nodes and just hard code it in the driver. Then how will other DT nodes reference the correct one? -- M?ns Rullg?rd mans@mansr.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/