Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162882AbbKTQhH (ORCPT ); Fri, 20 Nov 2015 11:37:07 -0500 Received: from mail-ig0-f174.google.com ([209.85.213.174]:33200 "EHLO mail-ig0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760619AbbKTQhF convert rfc822-to-8bit (ORCPT ); Fri, 20 Nov 2015 11:37:05 -0500 MIME-Version: 1.0 Reply-To: cw00.choi@samsung.com In-Reply-To: References: <1447350781-20649-1-git-send-email-balbi@ti.com> <1447351034-21150-1-git-send-email-balbi@ti.com> <564EB0A6.4060407@samsung.com> <564EB332.5090406@samsung.com> <87io4wenz5.fsf@saruman.tx.rr.com> Date: Sat, 21 Nov 2015 01:37:04 +0900 Message-ID: Subject: Re: [PATCH] extcon: palmas: add support for using VBUSDET output From: Chanwoo Choi To: Chanwoo Choi Cc: Tony Lindgren , Rob Herring , MyungJoo Ham , Linux OMAP Mailing List , Linux ARM Kernel Mailing List , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3633 Lines: 98 Hi, On Sat, Nov 21, 2015 at 12:05 AM, Chanwoo Choi wrote: > Hi Felipe, > > On Fri, Nov 20, 2015 at 11:37 PM, Felipe Balbi wrote: >> >> Hi Chanwoo, >> >> Chanwoo Choi writes: >>> Hi Felipe, >>> >>> On 2015년 11월 20일 14:33, Chanwoo Choi wrote: >>>> Hi Felipe, >>>> >>>> Looks good to me. But I have one comment. >>>> >>>> On 2015년 11월 13일 02:57, Felipe Balbi wrote: >>>>> TPS659038 can remux its GPIO_1 as VBUSDET output, >>>>> which can be tied to a SoC GPIO and used as a VBUS >>>>> interrupt. >>>>> >>>>> Beagle X15 uses that, in fact, and without it, I >>>>> could not get USB peripheral working with that >>>>> board. >>>>> >>>>> Signed-off-by: Felipe Balbi >>>>> --- >>>>> drivers/extcon/extcon-palmas.c | 22 ++++++++++++++++++++-- >>>>> 1 file changed, 20 insertions(+), 2 deletions(-) >>>>> >>>>> diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c >>>>> index 93c30a885740..7985d092c069 100644 >>>>> --- a/drivers/extcon/extcon-palmas.c >>>>> +++ b/drivers/extcon/extcon-palmas.c >>>>> @@ -296,10 +296,28 @@ static int palmas_usb_probe(struct platform_device *pdev) >>>>> } >>>>> >>>>> if (palmas_usb->enable_vbus_detection) { >>>>> + int irq = platform_get_irq(pdev, 0); >>>>> + >>>>> + if (irq > 0) { >>>>> + /* remux GPIO_1 as VBUSDET */ >>>>> + status = palmas_update_bits(palmas, PALMAS_PU_PD_OD_BASE, >>>>> + PALMAS_PRIMARY_SECONDARY_PAD1, >>>>> + PALMAS_PRIMARY_SECONDARY_PAD1_GPIO_1_MASK, >>>>> + (1 << 3)); >>>> >>>> PALMAS_PRIMARY_SECONDARY_PAD1_GPIO_1_SHIFT is appropriate instead of >>>> using '3'. >> >> good point :-) >> >>>>> + if (status < 0) { >>>>> + dev_err(&pdev->dev, "can't remux GPIO1\n"); >>>>> + return status; >>>>> + } >>>>> + >>>>> + palmas_usb->vbus_irq = irq; >>>>> + } else { >>>>> + irq = regmap_irq_get_virq(palmas->irq_data, >>>>> + PALMAS_VBUS_IRQ); >>>>> + palmas_usb->vbus_irq = irq; >>>>> + } >>>>> + >>>>> palmas_usb->vbus_otg_irq = regmap_irq_get_virq(palmas->irq_data, >>>>> PALMAS_VBUS_OTG_IRQ); >>>>> - palmas_usb->vbus_irq = regmap_irq_get_virq(palmas->irq_data, >>>>> - PALMAS_VBUS_IRQ); >>>>> status = devm_request_threaded_irq(palmas_usb->dev, >>>>> palmas_usb->vbus_irq, NULL, >>>>> palmas_vbus_irq_handler, >>>>> >>>> >>>> Thanks, >>>> Chanwoo Choi >>>> -- >>>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >>>> the body of a message to majordomo@vger.kernel.org >>>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>>> Please read the FAQ at http://www.tux.org/lkml/ >>>> >>> >>> If you are OK about following patch, I'll apply it on extcon branch. >> >> that's perfect, thanks for fixing it :-) > > Applied it. Please ignore this reply about applies because I need to discuss about it. Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/