Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760828AbbKTQwD (ORCPT ); Fri, 20 Nov 2015 11:52:03 -0500 Received: from mail-wm0-f44.google.com ([74.125.82.44]:33015 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760794AbbKTQv7 (ORCPT ); Fri, 20 Nov 2015 11:51:59 -0500 Subject: Re: [PATCH] watchdog: mtk_wdt: Use MODE_KEY when stopping the watchdog To: Guenter Roeck , Nicolas Boichat References: <1447814701-23504-1-git-send-email-drinkcat@chromium.org> <564CA620.7080700@roeck-us.net> Cc: Wim Van Sebroeck , linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org From: Matthias Brugger Message-ID: <564F4FAB.8000703@gmail.com> Date: Fri, 20 Nov 2015 17:51:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <564CA620.7080700@roeck-us.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1202 Lines: 39 On 18/11/15 17:24, Guenter Roeck wrote: > On 11/17/2015 06:45 PM, Nicolas Boichat wrote: >> WDT_MODE value need to be or-ed with MODE_KEY when setting >> watchdog mode. Add it to mtk_wdt_stop function, so that the >> watchdog can be stopped (e.g. during suspend). >> >> Signed-off-by: Nicolas Boichat > > Reviewed-by: Guenter Roeck Acked-by: Matthias Brugger > >> --- >> drivers/watchdog/mtk_wdt.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/watchdog/mtk_wdt.c b/drivers/watchdog/mtk_wdt.c >> index 6ad9df9..b751f43 100644 >> --- a/drivers/watchdog/mtk_wdt.c >> +++ b/drivers/watchdog/mtk_wdt.c >> @@ -123,6 +123,7 @@ static int mtk_wdt_stop(struct watchdog_device >> *wdt_dev) >> >> reg = readl(wdt_base + WDT_MODE); >> reg &= ~WDT_MODE_EN; >> + reg |= WDT_MODE_KEY; >> iowrite32(reg, wdt_base + WDT_MODE); >> >> return 0; >> > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/