Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162862AbbKTQzY (ORCPT ); Fri, 20 Nov 2015 11:55:24 -0500 Received: from mail-io0-f174.google.com ([209.85.223.174]:34949 "EHLO mail-io0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759522AbbKTQzX convert rfc822-to-8bit (ORCPT ); Fri, 20 Nov 2015 11:55:23 -0500 MIME-Version: 1.0 Reply-To: cw00.choi@samsung.com In-Reply-To: <564F4D90.4050305@gmail.com> References: <1447350781-20649-1-git-send-email-balbi@ti.com> <1447350781-20649-3-git-send-email-balbi@ti.com> <564EB215.5080209@samsung.com> <564F4D90.4050305@gmail.com> Date: Sat, 21 Nov 2015 01:55:22 +0900 Message-ID: Subject: Re: [PATCH 2/2] arm: boot: beaglex15: pass correct interrupt From: Chanwoo Choi To: Chanwoo Choi , Felipe Balbi , Tony Lindgren , Rob Herring , MyungJoo Ham Cc: Linux OMAP Mailing List , Linux ARM Kernel Mailing List , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2513 Lines: 74 Hi, On Sat, Nov 21, 2015 at 1:42 AM, Chanwoo Choi wrote: > Hi, > > On 2015. 11. 20. 오후 2:39, Chanwoo Choi wrote: >> Hi, >> >> On 2015년 11월 13일 02:53, Felipe Balbi wrote: >>> According to latest schematics [1], GPIO_1/VBUSDET >>> on TPS659038 is tied to AM57x GPIO4_21. We can use >>> that as a VBUS interrupt, instead of relying on >>> PMIC's VBUS interrupts which don't seem to be firing >>> on x15 at all. >>> >>> A follow up patch will add support for using this >>> GPIO-based interrupt mechanism for notifying about >>> VBUS. >>> >>> [1] https://github.com/beagleboard/beagleboard-x15/blob/master/BeagleBoard-X15_RevA2.pdf >>> >>> Signed-off-by: Felipe Balbi >>> --- >>> arch/arm/boot/dts/am57xx-beagle-x15.dts | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/arch/arm/boot/dts/am57xx-beagle-x15.dts b/arch/arm/boot/dts/am57xx-beagle-x15.dts >>> index 6f3a1a7ec5f9..5e47162f7883 100644 >>> --- a/arch/arm/boot/dts/am57xx-beagle-x15.dts >>> +++ b/arch/arm/boot/dts/am57xx-beagle-x15.dts >>> @@ -560,6 +560,7 @@ >>> extcon_usb2: tps659038_usb { >>> compatible = "ti,palmas-usb-vid"; >>> ti,enable-vbus-detection; >>> + interrupts-extended = <&gpio4 21 IRQ_TYPE_EDGE_RISING>; > > vbus-gpio = <&gpio4 21>; I'm sorry. I'm sending the missing email without writing completion. I agree the Felipe's opinion. Just I think that we can use the following property instead of 'interrupt-extended'. Because I think 'vbus-gpio' is more readability than before. The following property mean the attribute of GPIO pin as VBUS. - vbus-gpio = <&gpio4 21>; Thanks, Chanwoo Choi > >>> }; >>> >>> }; >>> >> >> I check the schematic file. The GPIO4_21 pin is connected as following: >> - GPIO_1/VBUSDET -> PMIC_VBUS_DET -> VBUS_DET -> AM5728 GPIO4_21 pin >> >> Reviewed-by: Chanwoo Choi >> >> Thanks, >> Chanwoo Choi >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/ >> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/