Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760860AbbKTQ4e (ORCPT ); Fri, 20 Nov 2015 11:56:34 -0500 Received: from mail-wm0-f44.google.com ([74.125.82.44]:38709 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760785AbbKTQ4Y (ORCPT ); Fri, 20 Nov 2015 11:56:24 -0500 Subject: Re: [PATCH 3/4] spi: mediatek: remove needless pair of writel()/readl() To: Leilk Liu , Mark Brown References: <1447986080-31410-1-git-send-email-leilk.liu@mediatek.com> <1447986080-31410-3-git-send-email-leilk.liu@mediatek.com> Cc: Mark Rutland , Sascha Hauer , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-mediatek@lists.infradead.org From: Matthias Brugger Message-ID: <564F50AA.50000@gmail.com> Date: Fri, 20 Nov 2015 17:56:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1447986080-31410-3-git-send-email-leilk.liu@mediatek.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1036 Lines: 32 On 20/11/15 03:21, Leilk Liu wrote: > It's not need to re-read and re-write SPI_CMD_REG, so remove it. > > Signed-off-by: Leilk Liu > --- > drivers/spi/spi-mt65xx.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/spi/spi-mt65xx.c b/drivers/spi/spi-mt65xx.c > index 7840067..6c1a96e 100644 > --- a/drivers/spi/spi-mt65xx.c > +++ b/drivers/spi/spi-mt65xx.c > @@ -154,9 +154,6 @@ static int mtk_spi_prepare_message(struct spi_master *master, > reg_val |= SPI_CMD_CPOL; > else > reg_val &= ~SPI_CMD_CPOL; > - writel(reg_val, mdata->base + SPI_CMD_REG); > - > - reg_val = readl(mdata->base + SPI_CMD_REG); > > /* set the mlsbx and mlsbtx */ > if (chip_config->tx_mlsb) > Reviewed-by: Matthias Brugger -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/