Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760907AbbKTRUv (ORCPT ); Fri, 20 Nov 2015 12:20:51 -0500 Received: from mail-ob0-f173.google.com ([209.85.214.173]:35288 "EHLO mail-ob0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760017AbbKTRUt (ORCPT ); Fri, 20 Nov 2015 12:20:49 -0500 MIME-Version: 1.0 In-Reply-To: <20151120154458.GA12090@rob-hp-laptop> References: <1447936001-21420-1-git-send-email-irina.tirdea@intel.com> <1447936001-21420-7-git-send-email-irina.tirdea@intel.com> <20151120154458.GA12090@rob-hp-laptop> Date: Fri, 20 Nov 2015 09:20:48 -0800 Message-ID: Subject: Re: [PATCH v11 6/8] Input: goodix - add support for ESD From: Dmitry Torokhov To: Rob Herring Cc: Irina Tirdea , Bastien Nocera , Aleksei Mamlin , Karsten Merker , "linux-input@vger.kernel.org" , Mark Rutland , Octavian Purdila , lkml , "devicetree@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1296 Lines: 37 On Fri, Nov 20, 2015 at 7:44 AM, Rob Herring wrote: > On Thu, Nov 19, 2015 at 02:26:39PM +0200, Irina Tirdea wrote: >> Add ESD (Electrostatic Discharge) protection mechanism. > > [...] > >> This is based on Goodix datasheets for GT911 and GT9271 and on Goodix >> driver gt9xx.c for Android (publicly available in Android kernel >> trees for various devices). >> >> Signed-off-by: Irina Tirdea >> For the binding: Acked-by: Rob Herring > > You should not have the "For the binding:" part here. It was just a note > so it was clear what part I looked at. > > It is preferred to split DT bindings to separate patches for this > reason. > It however does not make sense if one wants to research when and why something was changed. We do not split patches to .h files from .c either. Whenever I can I merge the driver and dt binding changes together if they have been posted and reviewed as separate patches. The Acks/Reviewed are mostly important for maintainers anyway. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/