Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760464AbbKTRze (ORCPT ); Fri, 20 Nov 2015 12:55:34 -0500 Received: from mail-wm0-f54.google.com ([74.125.82.54]:38109 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759625AbbKTRzc (ORCPT ); Fri, 20 Nov 2015 12:55:32 -0500 Subject: Re: [PATCH v2] clk: si5351: Add PLL soft reset To: Jacob Siverskog , Michael Turquette , Stephen Boyd , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org References: <1448040137-21400-1-git-send-email-jacob@teenage.engineering> <1448040137-21400-2-git-send-email-jacob@teenage.engineering> Cc: Belisko Marek , Jens Rudberg From: Sebastian Hesselbarth Message-ID: <564F5E8F.80709@gmail.com> Date: Fri, 20 Nov 2015 18:55:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 In-Reply-To: <1448040137-21400-2-git-send-email-jacob@teenage.engineering> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1896 Lines: 55 On 20.11.2015 18:22, Jacob Siverskog wrote: > This is according to figure 12 ("I2C Programming Procedure") in > "Si5351A/B/C Data Sheet" > (https://www.silabs.com/Support%20Documents/TechnicalDocs/Si5351-B.pdf). > > Without the PLL soft reset, we were unable to get three outputs > working at the same time. > > According to Silicon Labs support, performing PLL soft reset will only > be noticeable if the PLL parameters have been changed. > > Signed-off-by: Jacob Siverskog > Signed-off-by: Jens Rudberg > --- > drivers/clk/clk-si5351.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/clk/clk-si5351.c b/drivers/clk/clk-si5351.c > index e346b22..984c058 100644 > --- a/drivers/clk/clk-si5351.c > +++ b/drivers/clk/clk-si5351.c > @@ -1091,6 +1091,12 @@ static int si5351_clkout_set_rate(struct clk_hw *hw, unsigned long rate, > si5351_set_bits(hwdata->drvdata, SI5351_CLK0_CTRL + hwdata->num, > SI5351_CLK_POWERDOWN, 0); > > + /* do a pll soft reset on both plls, needed in some cases to get all > + * outputs running > + */ Common convention for multi-line comments usually is: /* * Do a PLL soft reset on both PLLs required to get * all outputs running. */ After you fixed the style issue, you can add my Acked-by: Sebastian Hesselbarth Thanks! > + si5351_reg_write(hwdata->drvdata, SI5351_PLL_RESET, > + SI5351_PLL_RESET_A | SI5351_PLL_RESET_B); > + > dev_dbg(&hwdata->drvdata->client->dev, > "%s - %s: rdiv = %u, parent_rate = %lu, rate = %lu\n", > __func__, clk_hw_get_name(hw), (1 << rdiv), > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/