Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162772AbbKTSDf (ORCPT ); Fri, 20 Nov 2015 13:03:35 -0500 Received: from mail-lb0-f181.google.com ([209.85.217.181]:32792 "EHLO mail-lb0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759900AbbKTSDY (ORCPT ); Fri, 20 Nov 2015 13:03:24 -0500 From: Jacob Siverskog To: Michael Turquette , Stephen Boyd , Sebastian Hesselbarth , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Cc: Belisko Marek , Jacob Siverskog , Jens Rudberg Subject: [PATCH v3 1/1] clk: si5351: Add PLL soft reset Date: Fri, 20 Nov 2015 19:03:13 +0100 Message-Id: <1448042593-23670-2-git-send-email-jacob@teenage.engineering> X-Mailer: git-send-email 2.6.3 In-Reply-To: <1448042593-23670-1-git-send-email-jacob@teenage.engineering> References: <564F5E8F.80709@gmail.com> <1448042593-23670-1-git-send-email-jacob@teenage.engineering> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1598 Lines: 43 This is according to figure 12 ("I2C Programming Procedure") in "Si5351A/B/C Data Sheet" (https://www.silabs.com/Support%20Documents/TechnicalDocs/Si5351-B.pdf). Without the PLL soft reset, we were unable to get three outputs working at the same time. According to Silicon Labs support, performing PLL soft reset will only be noticeable if the PLL parameters have been changed. Signed-off-by: Jacob Siverskog Signed-off-by: Jens Rudberg Acked-by: Sebastian Hesselbarth --- drivers/clk/clk-si5351.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/clk/clk-si5351.c b/drivers/clk/clk-si5351.c index e346b22..850316a 100644 --- a/drivers/clk/clk-si5351.c +++ b/drivers/clk/clk-si5351.c @@ -1091,6 +1091,13 @@ static int si5351_clkout_set_rate(struct clk_hw *hw, unsigned long rate, si5351_set_bits(hwdata->drvdata, SI5351_CLK0_CTRL + hwdata->num, SI5351_CLK_POWERDOWN, 0); + /* + * Do a pll soft reset on both plls, needed in some cases to get + * all outputs running. + */ + si5351_reg_write(hwdata->drvdata, SI5351_PLL_RESET, + SI5351_PLL_RESET_A | SI5351_PLL_RESET_B); + dev_dbg(&hwdata->drvdata->client->dev, "%s - %s: rdiv = %u, parent_rate = %lu, rate = %lu\n", __func__, clk_hw_get_name(hw), (1 << rdiv), -- 2.6.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/