Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760343AbbKTSJR (ORCPT ); Fri, 20 Nov 2015 13:09:17 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:41062 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759098AbbKTSJQ (ORCPT ); Fri, 20 Nov 2015 13:09:16 -0500 Date: Fri, 20 Nov 2015 18:08:54 +0000 From: Mark Brown To: Songjun Wu Cc: linux-arm-kernel@lists.infradead.org, Nicolas Ferre , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Message-ID: <20151120180854.GD1929@sirena.org.uk> References: <1447903590-3285-1-git-send-email-songjun.wu@atmel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="F8dlzb82+Fcn6AgP" Content-Disposition: inline In-Reply-To: <1447903590-3285-1-git-send-email-songjun.wu@atmel.com> X-Cookie: A beer delayed is a beer denied. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] ASoC: Atmel: ClassD: Set GCK's parent clock X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1441 Lines: 41 --F8dlzb82+Fcn6AgP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Nov 19, 2015 at 11:26:30AM +0800, Songjun Wu wrote: > Set GCK's parent clock as audio clock, make > sure the GCK's parent clock is audio clock. > + ret = clk_set_parent(dd->gclk, dd->aclk); > + if (ret) { > + dev_err(dev, "failed to set GCK parent clock: %d\n", ret); > + return ret; > + } Why are we doing this in the driver? This should be done by whatever creates the clock tree, not by the driver that uses the clocks - that way if some future SoC has a different clock tree the driver will continue to work. --F8dlzb82+Fcn6AgP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWT2G1AAoJECTWi3JdVIfQk1sIAIDTRZKUJ1ae7Vcd7VdtR9yl t1RQ7QAreyf1/DhVm6MoyZnqfSSYmT1925i3uk0K2yAFt82Q8CKgQXMW+N6ANwZE /kTsPXk9NM6IkQxmorQdkLVm51s0g9kpSOXMFE7PsGzr3AG9zv9vpefoCBd4lxEy +dgOeu/Hq5aqpH7OcaLMIUjooPCteue9f9CJcW3ng/znqMvVbjDbFVu6VDkt8b3t 7Iebvr7NminVpkvUhTN9SP7HQryk8cN76cXT+AYkzxQf5GZawELpIufdzQrezNjS zomr1jMVHfMiIl/PuMEVxQaPch5oYgsYCL2KBp7xwAgz/h25sdaRZ/fqzKre7Oo= =m7Lc -----END PGP SIGNATURE----- --F8dlzb82+Fcn6AgP-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/