Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760444AbbKTSgD (ORCPT ); Fri, 20 Nov 2015 13:36:03 -0500 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:39713 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759633AbbKTSgA (ORCPT ); Fri, 20 Nov 2015 13:36:00 -0500 From: Jens Axboe Subject: Re: [PATCH] mtip32xx: use formatting capability of kthread_create_on_node To: Rasmus Villemoes , Asai Thambi SP , Jeff Moyer References: <1448012809-15462-1-git-send-email-linux@rasmusvillemoes.dk> CC: Message-ID: <564F680B.2060301@fb.com> Date: Fri, 20 Nov 2015 11:35:55 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1448012809-15462-1-git-send-email-linux@rasmusvillemoes.dk> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.54.13] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-11-20_11:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 582 Lines: 16 On 11/20/2015 02:46 AM, Rasmus Villemoes wrote: > kthread_create_on_node takes format+args, so there's no need to do the > pretty-printing in advance. Moreover, "mtip_svc_thd_99" (including its > '\0') only just fits in 16 bytes, so if index could ever go above 99 > we'd have a stack buffer overflow. Applied, thanks. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/