Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760973AbbKTVTh (ORCPT ); Fri, 20 Nov 2015 16:19:37 -0500 Received: from mail-wm0-f44.google.com ([74.125.82.44]:33371 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751895AbbKTVTg (ORCPT ); Fri, 20 Nov 2015 16:19:36 -0500 Subject: Re: [PATCH 2/2] arm64: dts: berlin4ct: enable all i2c nodes for the STB board To: Jisheng Zhang , robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, catalin.marinas@arm.com, will.deacon@arm.com References: <1448012821-7413-1-git-send-email-jszhang@marvell.com> <1448012821-7413-3-git-send-email-jszhang@marvell.com> Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: Sebastian Hesselbarth Message-ID: <564F8E64.7020606@gmail.com> Date: Fri, 20 Nov 2015 22:19:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 In-Reply-To: <1448012821-7413-3-git-send-email-jszhang@marvell.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2091 Lines: 101 On 20.11.2015 10:47, Jisheng Zhang wrote: > Enable all i2c nodes for the Marvell berlin BG4CT STB board. > > Signed-off-by: Jisheng Zhang > --- > arch/arm64/boot/dts/marvell/berlin4ct-stb.dts | 50 +++++++++++++++++++++++++++ > 1 file changed, 50 insertions(+) > > diff --git a/arch/arm64/boot/dts/marvell/berlin4ct-stb.dts b/arch/arm64/boot/dts/marvell/berlin4ct-stb.dts > index 348c37e..9e8e2e0 100644 > --- a/arch/arm64/boot/dts/marvell/berlin4ct-stb.dts > +++ b/arch/arm64/boot/dts/marvell/berlin4ct-stb.dts > @@ -61,6 +61,56 @@ > }; > }; > > +&avio_pinctrl { > + twsi1_pmux: twsi1-pmux { > + groups = "TX_EDDC_SCL", "TX_EDDC_SDA"; > + function = "tx_eddc"; > + }; Please keep the pinmux sub-nodes in the SoC dtsi as long as they are not strictly board specific, i.e. gpios. > +}; > + > +&i2c0 { > + status = "okay"; > + pinctrl-0 = <&twsi0_pmux>; > + pinctrl-names = "default"; If there is only one (or a default) pinctrl-0 option for i2c0, you can also move it to the SoC dtsi. > +}; > + > +&i2c1 { > + status = "okay"; > + pinctrl-0 = <&twsi1_pmux>; > + pinctrl-names = "default"; ditto. > +}; > + > +&i2c2 { > + status = "okay"; > + pinctrl-0 = <&twsi2_pmux>; > + pinctrl-names = "default"; ditto. > +}; > + > +&i2c3 { > + status = "okay"; > + pinctrl-0 = <&twsi3_pmux>; > + pinctrl-names = "default"; ditto. > +}; > + > +&soc_pinctrl { > + twsi0_pmux: twsi0-pmux { > + groups = "TW0_SCL", "TW0_SDA"; > + function = "tw0"; > + }; Same comment about moving pinmux nodes to SoC dtsi. > +}; > + > +&system_pinctrl { > + twsi2_pmux: twsi2-pmux { > + groups = "SM_TW2_SCL", "SM_TW2_SDA"; > + function = "tw2"; > + }; > + > + twsi3_pmux: twsi3-pmux { > + groups = "SM_TW3_SCL", "SM_TW3_SDA"; > + function = "tw3"; > + }; ditto. Sebastian > +}; > + > &uart0 { > status = "okay"; > }; > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/