Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761056AbbKTWAb (ORCPT ); Fri, 20 Nov 2015 17:00:31 -0500 Received: from mail-pa0-f44.google.com ([209.85.220.44]:32927 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760532AbbKTWAa (ORCPT ); Fri, 20 Nov 2015 17:00:30 -0500 Date: Fri, 20 Nov 2015 14:00:16 -0800 From: Nicolin Chen To: Rob Herring Cc: Shengjiu Wang , pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, timur@tabi.org, Xiubo.Lee@gmail.com, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, shawnguo@kernel.org, alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH V2 3/3] ASoC: fsl_asrc: spba clock is needed by asrc device Message-ID: <20151120220015.GA10156@Asurada> References: <7b40da78c965d4152c15794ec527c75198c9e2f9.1447997800.git.shengjiu.wang@freescale.com> <20151120142946.GA6949@rob-hp-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151120142946.GA6949@rob-hp-laptop> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1671 Lines: 35 On Fri, Nov 20, 2015 at 08:29:46AM -0600, Rob Herring wrote: > On Fri, Nov 20, 2015 at 02:17:53PM +0800, Shengjiu Wang wrote: > > ASRC need to enable the spba clock, when sdma is using share peripheral > > script. In this case, there is two spba master port is used, if don't > > enable the clock, the spba bus will have arbitration issue, which may > > cause read/write wrong data from/to ASRC registers > > > > Signed-off-by: Shengjiu Wang > > --- > > Documentation/devicetree/bindings/sound/fsl,asrc.txt | 2 ++ > > sound/soc/fsl/fsl_asrc.c | 10 ++++++++++ > > sound/soc/fsl/fsl_asrc.h | 1 + > > 3 files changed, 13 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/sound/fsl,asrc.txt b/Documentation/devicetree/bindings/sound/fsl,asrc.txt > > index b93362a..d8eeee3 100644 > > --- a/Documentation/devicetree/bindings/sound/fsl,asrc.txt > > +++ b/Documentation/devicetree/bindings/sound/fsl,asrc.txt > > @@ -25,6 +25,8 @@ Required properties: > > "mem" Peripheral access clock to access registers. > > "ipg" Peripheral clock to driver module. > > "asrck_<0-f>" Clock sources for input and output clock. > > + "spba" The spba clock is needed when two spba master port > > + is used. > > I'm assuming the same comments on patch 1 apply to all 3. Yes. I should have mentioned that. Nicolin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/