Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422809AbbKTXsR (ORCPT ); Fri, 20 Nov 2015 18:48:17 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:22295 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422679AbbKTXsO (ORCPT ); Fri, 20 Nov 2015 18:48:14 -0500 Subject: Re: [PATCH 1/1] soc: ti: knav_qmss_queue: Fix linking RAM setup for queue managers To: Michal Morawiec , Santosh Shilimkar References: <1448062781-6708-1-git-send-email-michal.1.morawiec.ext@nokia.com> Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Michal Morawiec From: santosh shilimkar Organization: Oracle Corporation Message-ID: <564FB11A.3020906@oracle.com> Date: Fri, 20 Nov 2015 15:47:38 -0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1448062781-6708-1-git-send-email-michal.1.morawiec.ext@nokia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1211 Lines: 34 On 11/20/2015 3:39 PM, Michal Morawiec wrote: > Configure linking RAM for both queue managers also in case > when only linking RAM 0 is specified in device tree. > why ? > Signed-off-by: Michal Morawiec > --- > drivers/soc/ti/knav_qmss_queue.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_queue.c > index 6d8646d..a809c30 100644 > --- a/drivers/soc/ti/knav_qmss_queue.c > +++ b/drivers/soc/ti/knav_qmss_queue.c > @@ -1173,7 +1173,7 @@ static int knav_queue_setup_link_ram(struct knav_device *kdev) > > block++; > if (!block->size) > - return 0; > + continue; > You have to expand this a bit for me. Because you really don't want kernel code to run the configuration on hardware which doesn't exist. I mean device tree suppose to specify the linking RAM for both QMs unless and until there is a reason not too. Regards, Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/