Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760765AbbKUAhI (ORCPT ); Fri, 20 Nov 2015 19:37:08 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:56142 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752011AbbKUAhE (ORCPT ); Fri, 20 Nov 2015 19:37:04 -0500 Date: Fri, 20 Nov 2015 16:37:02 -0800 From: Stephen Boyd To: Masahiro Yamada Cc: linux-clk@vger.kernel.org, Michael Turquette , linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] clk: split of_clk_get_parent_name() into two functions Message-ID: <20151121003702.GC28998@codeaurora.org> References: <1448004981-11133-1-git-send-email-yamada.masahiro@socionext.com> <1448004981-11133-3-git-send-email-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1448004981-11133-3-git-send-email-yamada.masahiro@socionext.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1499 Lines: 43 On 11/20, Masahiro Yamada wrote: > Currently, there is no function to get the clock name of the given > node. Create a new helper function, of_clk_get_name(). This is > useful to get the clock name where "clock-indices" property is used. > > of_clk_get_name(): get the clock name in the given node > of_clk_get_parent_name(): get the name of the parent clock > > Signed-off-by: Masahiro Yamada > --- > > I want to use of_clk_get_name() for my clk drivers for my SoCs, > which I will submit later. > > I found this helper function is useful. I don't see how this is useful. Is the new driver so generic it doesn't know what clocks it's outputting? We've been trying to move people away from using clock-output-names, so most likely this sort of information should be conveyed from DT via the compatible string and a table in the driver that matches up the compatible string with the list of clock names. > @@ -3102,7 +3114,6 @@ const char *of_clk_get_parent_name(struct device_node *np, int index) > } > } > > - Noise. Please remove. > of_node_put(clkspec.np); > return clk_name; > } -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/