Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162940AbbKUAti (ORCPT ); Fri, 20 Nov 2015 19:49:38 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:55347 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760389AbbKUAtg (ORCPT ); Fri, 20 Nov 2015 19:49:36 -0500 Date: Fri, 20 Nov 2015 16:49:33 -0800 From: Darren Hart To: Azael Avalos Cc: "platform-driver-x86@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/1] toshiba_acpi: Propagate the hotkey value via genetlink Message-ID: <20151121004933.GO7413@malice.jf.intel.com> References: <1447644827-404-1-git-send-email-coproscefalo@gmail.com> <20151120231937.GD7413@malice.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1708 Lines: 44 On Fri, Nov 20, 2015 at 05:05:37PM -0700, Azael Avalos wrote: > Hi Darren, > > 2015-11-20 16:19 GMT-07:00 Darren Hart : > > On Sun, Nov 15, 2015 at 08:33:46PM -0700, Azael Avalos wrote: > >> The driver uses genetlink to inform userspace of events generated by > >> the system, but the data passed is always zero as there is no data to > >> pass, except for the hotkey event. > >> > >> This patch propagates the hotkey value via genetlink so userspace can > >> make use of it. > > > > Which keys were not working previously? > > It's not about the keys, but the "extra events" generated, I still do not > know why Toshiba sent system events inside the hotkey event (maybe > they ran out of numbers...). > > > > > My concern is that we introduce new events that then get "double handled". > > > > Well, the events are already being generated, but they are Toshiba specific > events, the only thing here that changed is that now we pass the hotkey value > to userspace, and as said, some of the system events that were not passed > before and are not handled at all. > > A good example here are the 0x1ABE and 0x1ABF events, which fire (on > certain laptops) when the HDD protection level changes and is disabled > respectively. > > There a re a lot of unknown events that are being sent as hotkeys, but > I still have to ideintify them :-( Thanks for the context, queued to testing. -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/