Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761303AbbKUA5q (ORCPT ); Fri, 20 Nov 2015 19:57:46 -0500 Received: from mail-gw3-out.broadcom.com ([216.31.210.64]:27427 "EHLO mail-gw3-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760809AbbKUA5p (ORCPT ); Fri, 20 Nov 2015 19:57:45 -0500 X-IronPort-AV: E=Sophos;i="5.20,325,1444719600"; d="scan'208";a="81014288" Subject: Re: [PATCH 2/3] clk: iproc: Add support for Cygnus audio clocks To: Stephen Boyd References: <1447870089-2382-1-git-send-email-rjui@broadcom.com> <1447870089-2382-3-git-send-email-rjui@broadcom.com> <20151121002119.GA28998@codeaurora.org> CC: Michael Turquette , , , , Simran Rai From: Ray Jui Message-ID: <564FC186.5010608@broadcom.com> Date: Fri, 20 Nov 2015 16:57:42 -0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151121002119.GA28998@codeaurora.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1446 Lines: 41 On 11/20/2015 4:21 PM, Stephen Boyd wrote: > On 11/18, Ray Jui wrote: >> diff --git a/drivers/clk/bcm/clk-iproc.h b/drivers/clk/bcm/clk-iproc.h >> index 8988de7..e2a7748 100644 >> --- a/drivers/clk/bcm/clk-iproc.h >> +++ b/drivers/clk/bcm/clk-iproc.h >> @@ -194,5 +215,11 @@ void __init iproc_asiu_setup(struct device_node *node, >> const struct iproc_asiu_div *div, >> const struct iproc_asiu_gate *gate, >> unsigned int num_clks); >> +void __init iproc_audiopll_clk_setup(struct device_node *node, >> + const struct iproc_pll_ctrl *pll_ctrl, >> + const struct iproc_pll_vco_param *vco, >> + unsigned int num_vco_entries, >> + const struct iproc_clk_ctrl *clk_ctrl, >> + unsigned int num_clks); > > We don't need __init in header files. And is this even used or > defined anywhere? > Does it make more sense if I add an incremental patch to remove all of the __init in this header? Ah, this is a mistake. cygnus_audiopll_clk_init is already defined in clk-cygnus.c and is meant to call iproc_pll_clk_setup to set up the clock. iproc_pll_clk_setup is already declared in this header. iproc_audiopll_clk_setup should be removed here. Thanks, Ray -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/