Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755648AbbKUMCx (ORCPT ); Sat, 21 Nov 2015 07:02:53 -0500 Received: from unicorn.mansr.com ([81.2.72.234]:57524 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751054AbbKUMCv convert rfc822-to-8bit (ORCPT ); Sat, 21 Nov 2015 07:02:51 -0500 From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Wolfram Sang Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] i2c: xlr: add support for Sigma Designs controller variant References: <1446429818-24155-1-git-send-email-mans@mansr.com> Date: Sat, 21 Nov 2015 12:02:48 +0000 In-Reply-To: <1446429818-24155-1-git-send-email-mans@mansr.com> (Mans Rullgard's message of "Mon, 2 Nov 2015 02:03:36 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1020 Lines: 29 Mans Rullgard writes: > Sigma Designs chips use a variant of this controller with the following > differences: > > - The BUSY bit in the STATUS register is inverted > - Bit 8 of the CONFIG register must be set > - The controller can generate interrupts > > This patch adds support for the first two of these. It also calculates > and sets the correct clock divisor if a clk is provided. The bus > frequency is optionally speficied in the device tree node. > > Signed-off-by: Mans Rullgard > --- > drivers/i2c/busses/Kconfig | 6 ++-- > drivers/i2c/busses/i2c-xlr.c | 81 +++++++++++++++++++++++++++++++++++++++++--- > 2 files changed, 80 insertions(+), 7 deletions(-) Any comments on these patches? -- M?ns Rullg?rd mans@mansr.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/