Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761065AbbKUPJ0 (ORCPT ); Sat, 21 Nov 2015 10:09:26 -0500 Received: from mga01.intel.com ([192.55.52.88]:25940 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760742AbbKUPJY convert rfc822-to-8bit (ORCPT ); Sat, 21 Nov 2015 10:09:24 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,328,1444719600"; d="scan'208";a="844213327" From: "Drokin, Oleg" To: Paul Davies C CC: "" , "" , "" , "" Subject: Re: [PATCH] staging: lustre: lov: Fix sparse warning Thread-Topic: [PATCH] staging: lustre: lov: Fix sparse warning Thread-Index: AQHRJDZWz9lfGecVikGI2uExSWXTh56nGuMA Date: Sat, 21 Nov 2015 15:09:22 +0000 Message-ID: <6F4A320D-0C7C-4F7F-B3AD-D241A22F6F51@intel.com> References: <56502ab9.8e4b620a.55593.5357@mx.google.com> In-Reply-To: <56502ab9.8e4b620a.55593.5357@mx.google.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.252.205.183] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1841 Lines: 50 Hello! On Nov 21, 2015, at 3:26 AM, Paul Davies C wrote: > This patch fixes the following warnings:- > > drivers/staging/lustre/lustre/lov/lov_object.c:926:22: warning: symbol 'lov_lsm_get' was not declared. Should it be static? > drivers/staging/lustre/lustre/lov/lov_object.c:942:6: warning: symbol 'lov_lsm_put' was not declared. Should it be static? > > Signed-off-by: Paul Davies C > --- > drivers/staging/lustre/lustre/lov/lov_object.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/lustre/lustre/lov/lov_object.c b/drivers/staging/lustre/lustre/lov/lov_object.c > index c7ff817..a667336 100644 > --- a/drivers/staging/lustre/lustre/lov/lov_object.c > +++ b/drivers/staging/lustre/lustre/lov/lov_object.c > @@ -923,7 +923,7 @@ static struct lov_stripe_md *lov_lsm_addref(struct lov_object *lov) > return lsm; > } > > -struct lov_stripe_md *lov_lsm_get(struct cl_object *clobj) > +static struct lov_stripe_md *lov_lsm_get(struct cl_object *clobj) > { > struct lu_object *luobj; > struct lov_stripe_md *lsm = NULL; > @@ -939,7 +939,7 @@ struct lov_stripe_md *lov_lsm_get(struct cl_object *clobj) > } > EXPORT_SYMBOL(lov_lsm_get); You did not compile-tested this, did you? This symbol is still used in lustre/lclient/lcommon_cl.c but also leaving EXPORT_SYMBOL intact for a static symbol? > > -void lov_lsm_put(struct cl_object *unused, struct lov_stripe_md *lsm) > +static void lov_lsm_put(struct cl_object *unused, struct lov_stripe_md *lsm) > { > if (lsm != NULL) > lov_free_memmd(&lsm); > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/