Subject: Re: [PATCH] drm/radeon: Retry DDC probing on DVI on failure if we got
 an HPD interrupt
To: Daniel Stone <daniel@fooishbar.org>
References: <1448034740-30193-1-git-send-email-cpaul@redhat.com>
 <56507E0F.7030009@amd.com>
 <CAPj87rPBMPgayZnxvVnJgyF+nm1rXJuNAdnYqZa29ZO3AQHB8Q@mail.gmail.com>
CC: <cpaul@redhat.com>, Alex Deucher <alexander.deucher@amd.com>,
        David Airlie <airlied@linux.ie>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
        Jerome Glisse <jglisse@redhat.com>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>
From: =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
Message-ID: <56508C34.1030909@amd.com>
Date: Sat, 21 Nov 2015 16:22:28 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <CAPj87rPBMPgayZnxvVnJgyF+nm1rXJuNAdnYqZa29ZO3AQHB8Q@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2015 15:22:47.4354
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0134
X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0043;2:He8pqAUMgvm5XI7G7SVJZk4ExhIVg2jw/w4Q5DMDqkKGJrEhYhJZBgMbUdcJJg/OILJgrFiFDHzqzYkXyE+X1Ad2YBVU2f8dQu39X5WSIBFGcX+0UzYgr1syrWOwfkr2r9NqUdfcnqZ588f49FqfWPOUhg2I+ZhEpSbDd3WuOm8=;23:2Jx5uL6VhLJYgXoRV8O8CY+xR1vDYRTf+y5owK3kuENajGf1g7+X3lIOqS8SaYpFTzl/9DS7PpQ7IiuBB+56YVVfzb+HVGw6bjkEhEFlTpjP+m3zu8LqIDS1YUPkB6XTR0tM/FFRW8SI0GM5rCBvtzS8sywsCjf6XYhfsI3GGVh/sb7/3HPAIo+/B4/078tY
X-OriginatorOrg: amd.com
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2145
Lines: 51

On 21.11.2015 15:49, Daniel Stone wrote:
> Hi,
>
> On 21 November 2015 at 14:22, Christian König <christian.koenig@amd.com> wrote:
>> On 20.11.2015 16:52, cpaul@redhat.com wrote:
>>> This is somewhat rare on most cards (depending on what angle you plug
>>> the DVI connector in), but on some cards it happens constantly. The
>>> Radeon R5 on the machine used for testing this patch for instance, runs
>>> into this issue just about every time I try to hotplug a DVI monitor and
>>> as a result hotplugging almost never works.
>>>
>>> Rescheduling the hotplug work for a second when we run into an HPD
>>> signal with a failing DDC probe usually gives enough time for the rest
>>> of the connector's pins to make contact, and fixes this issue.
>>>
>>> Signed-off-by: Stephen Chandler Paul <cpaul@redhat.com>
>>
>> Yeah, that's something I always wondered a about bit as well.
>>
>> Debouncing is something very common done in electronics, but as far as I
>> know the HPD pins don't necessary have an RC circuit so we might need to
>> handle this case in software here.
>>
>> A delay of something between 10-30ms between the last HPD interrupt and
>> further processing of the signal doesn't sounds like such a bad idea.
>>
>> Retrying on the other hand doesn't necessarily improve the situation cause
>> the delay introduced by this might not be enough.
>>
>> So I would rather vote for a fixed delay between an HPD interrupt and
>> actually starting to process anything.
> Yes-ish. Debouncing is useful, and ignoring buggy devices (e.g. those
> on marginal power) which send you HPD storms as well. But DP relies on
> 'short HPD' pulses which can be as brief as 2ms. So attempting to
> totally debounce all HPD won't work.
Well the discussion so far was about HPD on DVI only.

I'm not so deep into DP, but why should it uses HPD pulses of less than 2ms?

Regards,
Christian.

>
> Cheers,
> Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/