Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752460AbbKUULf (ORCPT ); Sat, 21 Nov 2015 15:11:35 -0500 Received: from mx2.suse.de ([195.135.220.15]:52695 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751156AbbKUULe (ORCPT ); Sat, 21 Nov 2015 15:11:34 -0500 Date: Sat, 21 Nov 2015 21:11:31 +0100 From: Jean Delvare To: LABBE Corentin Cc: wsa@the-dreams.de, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/1] i2c: taos-evm: replace simple_strtoul by kstrtou8 Message-ID: <20151121211131.16715ba3@endymion.delvare> In-Reply-To: <1447851356-6248-2-git-send-email-clabbe.montjoie@gmail.com> References: <1447851356-6248-1-git-send-email-clabbe.montjoie@gmail.com> <1447851356-6248-2-git-send-email-clabbe.montjoie@gmail.com> Organization: SUSE Linux X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.23; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1464 Lines: 47 Hi Corentin, On Wed, 18 Nov 2015 13:55:56 +0100, LABBE Corentin wrote: > The simple_strtoul function is marked as obsolete. > This patch replace it by kstrtou8. > > Signed-off-by: LABBE Corentin Reviewed-by: Jean Delvare Tested-by: Jean Delvare Note: when there's a single patch you don't have to send an email with PATCH 0/1. > --- > drivers/i2c/busses/i2c-taos-evm.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-taos-evm.c b/drivers/i2c/busses/i2c-taos-evm.c > index 4c7fc2d..f673f5d 100644 > --- a/drivers/i2c/busses/i2c-taos-evm.c > +++ b/drivers/i2c/busses/i2c-taos-evm.c > @@ -130,7 +130,13 @@ static int taos_smbus_xfer(struct i2c_adapter *adapter, u16 addr, > return 0; > } else { > if (p[0] == 'x') { > - data->byte = simple_strtol(p + 1, NULL, 16); > + /* > + * voluntarily dropping error code of kstrtou8 since all > + * error code that it could return are invalid according > + * to Documentation/i2c/fault-codes > + */ > + if (kstrtou8(p + 1, 16, &data->byte)) > + return -EPROTO; > return 0; > } > } -- Jean Delvare SUSE L3 Support -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/