Subject: Re: [PATCH V3 2/6] acpi: pci: Setup MSI domain for ACPI based pci
 devices
To: Marc Zyngier <marc.zyngier@arm.com>
References: <1445453249-32557-1-git-send-email-Suravee.Suthikulpanit@amd.com>
 <1445453249-32557-3-git-send-email-Suravee.Suthikulpanit@amd.com>
 <20151119120807.07ffd476@arm.com>
CC: <tglx@linutronix.de>, <jason@lakedaemon.net>, <rjw@rjwysocki.net>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Will Deacon <will.deacon@arm.com>,
        Catalin Marinas <Catalin.Marinas@arm.com>, <hanjun.guo@linaro.org>,
        <tomasz.nowicki@linaro.org>, <graeme.gregory@linaro.org>,
        <dhdang@apm.com>, <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <linux-acpi@vger.kernel.org>
From: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
Message-ID: <5650DFB5.2010809@amd.com>
Date: Sat, 21 Nov 2015 15:18:45 -0600
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0)
 Gecko/20100101 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <20151119120807.07ffd476@arm.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
SpamDiagnosticOutput: 1:23
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2015 21:18:38.9192 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR12MB0434
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2281
Lines: 76

Hi Marc,

On 11/19/15 06:08, Marc Zyngier wrote:
> On Wed, 21 Oct 2015 11:47:25 -0700
> Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com> wrote:
>
> Hi Suravee,
>
> Sorry it took so long to get to this series. Comments below.

No worry.

>
>> This patch introduces pci_host_bridge_acpi_msi_domain(), which returns
>> the MSI domain of the specified PCI host bridge with DOMAIN_BUS_PCI_MSI
>> bus token. Then, it is assigned to pci device.
>>
>> Signed-off-by: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
>> ---
>>   drivers/pci/pci-acpi.c | 13 +++++++++++++
>>   drivers/pci/probe.c    |  2 ++
>>   include/linux/pci.h    |  7 +++++++
>>   3 files changed, 22 insertions(+)
>>
>> diff --git a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c
>> index a32ba75..0e21ef4 100644
>> --- a/drivers/pci/pci-acpi.c
>> +++ b/drivers/pci/pci-acpi.c
>> @@ -9,7 +9,9 @@
>>
>>   #include <linux/delay.h>
>>   #include <linux/init.h>
>> +#include <linux/irqdomain.h>
>>   #include <linux/pci.h>
>> +#include <linux/msi.h>
>>   #include <linux/pci_hotplug.h>
>>   #include <linux/module.h>
>>   #include <linux/pci-aspm.h>
>> @@ -689,6 +691,17 @@ static struct acpi_bus_type acpi_pci_bus = {
>>   	.cleanup = pci_acpi_cleanup,
>>   };
>>
>> +struct irq_domain *pci_host_bridge_acpi_msi_domain(struct pci_bus *bus)
>> +{
>> +	struct irq_domain *dom = NULL;
>> +	struct fwnode_handle *fwnode = pci_msi_get_fwnode(&bus->dev);
>> +
>> +	if (fwnode)
>> +		dom = irq_find_matching_fwnode(fwnode,
>> +					       DOMAIN_BUS_PCI_MSI);
>> +	return dom;
>> +}
>> +
>
> Given this, I really question the need for what you define in patch #1
> to be standalone. It is only used by ACPI (DT has its own private
> helpers), and it is so far unlikely that it will be of any use for
> other firmware interfaces.
>
> My suggestion is to get rid of pci_msi_get_fwnode() and move the
> registration helper into this file. That'd be much simpler.
>
> Thanks,
>
> 	M.
>

Ok, I'll take care of this. I assume the rest of the patches looks ok.

Thanks,
Suravee
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/