Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761451AbbKVC6b (ORCPT ); Sat, 21 Nov 2015 21:58:31 -0500 Received: from mail-sn1nam02on0052.outbound.protection.outlook.com ([104.47.36.52]:26446 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752346AbbKVC60 (ORCPT ); Sat, 21 Nov 2015 21:58:26 -0500 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; hurleysoftware.com; dkim=none (message not signed) header.d=none;hurleysoftware.com; dmarc=bestguesspass action=none header.from=xilinx.com; From: Soren Brinkmann To: Greg Kroah-Hartman , Jiri Slaby CC: Michal Simek , , , , "Peter Hurley" , Soren Brinkmann Subject: [PATCH LINUX v3 00/10] tty: xuartps: Fix lock ups Date: Sat, 21 Nov 2015 18:59:22 -0800 Message-ID: <1448161172-19717-1-git-send-email-soren.brinkmann@xilinx.com> X-Mailer: git-send-email 2.6.3.3.g9bb996a MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-21954.006 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:149.199.60.83;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(199003)(189002)(47776003)(189998001)(86362001)(92566002)(63266004)(586003)(5001960100002)(107886002)(81156007)(57986006)(11100500001)(76506005)(229853001)(5001770100001)(50226001)(33646002)(106466001)(87936001)(50986999)(5007970100001)(23676002)(77096005)(6806005)(5820100001)(36386004)(36756003)(5008740100001)(4001430100002)(19580405001)(50466002)(107986001)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1NAM02HT142;H:xsj-pvapsmtpgw01;FPR:;SPF:Pass;PTR:unknown-60-83.xilinx.com;A:1;MX:1;LANG:en; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501001);SRVR:SN1NAM02HT142; X-Microsoft-Antispam-PRVS: <5c8935917a23416fb9e6433747359c08@SN1NAM02HT142.eop-nam02.prod.protection.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(520078)(3002001)(10201501046);SRVR:SN1NAM02HT142;BCL:0;PCL:0;RULEID:;SRVR:SN1NAM02HT142; X-Forefront-PRVS: 076804FE30 X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2015 02:58:24.2707 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1NAM02HT142 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2161 Lines: 68 Hi, here is v3 of this series. It's largely the same as before, but I adjusted 'tty: xuartps: Don't consider circular buffer when enabling transmitter' according to Peter's suggestions. I also spent some time trying to get Peter's test for flow control and xchar running. The xchar thing fails and will need some more work, but I think in general it should be possible to get it to work. The flow control test passes: root@Xilinx-ZC1751-DC1:~# ./flow /dev/ttyPS0 Test flow control on /dev/ttyPS0 begin test1 patterns sent: 223 recvd: 208 read distribution: 1 = 0 2+ = 0 4+ = 0 8+ = 0 16+ = 0 32+ = 643 64+ = 0 128+ = 0 256+ = 0 512+ = 0 PASSED root@Xilinx-ZC1751-DC1:~# ./flow /dev/ttyPS1 Test flow control on /dev/ttyPS1 begin test1 patterns sent: 223 recvd: 208 read distribution: 1 = 0 2+ = 0 4+ = 0 8+ = 0 16+ = 0 32+ = 643 64+ = 0 128+ = 0 256+ = 0 512+ = 0 PASSED Sören Sören Brinkmann (10): tty: xuartps: Beautify read-modify writes tty: xuartps: Use spinlock to serialize HW access tty: xuartps: Don't consider circular buffer when enabling transmitter tty: xuartps: Clear interrupt status register in shutdown tty: xuartps: Improve startup function tty: xuartps: Keep lock for whole ISR tty: xuartps: Acquire port lock for shutdown tty: xuartps: Move RX path into helper function tty: xuartps: Only handle RX IRQs when RX is enabled tty: xuartps: Cleanup: Reformat if-else drivers/tty/serial/xilinx_uartps.c | 246 +++++++++++++++++++++---------------- 1 file changed, 137 insertions(+), 109 deletions(-) -- 2.6.3.3.g9bb996a -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/