From: Yuval Mintz <Yuval.Mintz@qlogic.com>
To: Salil Mehta <salil.mehta@huawei.com>, David Miller <davem@davemloft.net>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "pawel.moll@arm.com" <pawel.moll@arm.com>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>,
        "paul.gortmaker@windriver.com" <paul.gortmaker@windriver.com>,
        "ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
        "galak@codeaurora.org" <galak@codeaurora.org>,
        "catalin.marinas@arm.com" <catalin.marinas@arm.com>,
        "will.deacon@arm.com" <will.deacon@arm.com>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "liguozhu@hisilicon.com" <liguozhu@hisilicon.com>,
        "yisen.zhuang@huawei.com" <yisen.zhuang@huawei.com>,
        "dingtianhong@huawei.com" <dingtianhong@huawei.com>,
        "zhangfei.gao@linaro.org" <zhangfei.gao@linaro.org>,
        "huangdaode@hisilicon.com" <huangdaode@hisilicon.com>,
        "kenneth-lee-2012@foxmail.com" <kenneth-lee-2012@foxmail.com>,
        "mehta.salil.lnk@gmail.com" <mehta.salil.lnk@gmail.com>,
        "xuwei5@hisilicon.com" <xuwei5@hisilicon.com>,
        "lisheng011@huawei.com" <lisheng011@huawei.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        netdev <netdev@vger.kernel.org>,
        "linuxarm@huawei.com" <linuxarm@huawei.com>
CC: yankejian <yankejian@huawei.com>, lipeng <lipeng321@huawei.com>,
        "Fengguang Wu" <fengguang.wu@intel.com>
Subject: RE: [PATCH V3 net-next 1/5] net:hns: Add support of Hip06 SoC to the
 Hislicon Network Subsystem
Thread-Topic: [PATCH V3 net-next 1/5] net:hns: Add support of Hip06 SoC to the
 Hislicon Network Subsystem
Thread-Index: AQHRIwuDN3QougAGVEiZzv2Nr+s0iZ6nwVNQ
Date: Sun, 22 Nov 2015 09:19:55 +0000
Message-ID: <CO2PR11MB0088145308CE8BF0C504C9C497180@CO2PR11MB0088.namprd11.prod.outlook.com>
References: <1447966706-16219-1-git-send-email-salil.mehta@huawei.com>
 <1447966706-16219-2-git-send-email-salil.mehta@huawei.com>
In-Reply-To: <1447966706-16219-2-git-send-email-salil.mehta@huawei.com>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:23
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Nov 2015 09:19:55.5501
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 0d68a1f9-1490-4d0e-8767-a87dab3ef2ba
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR11MB0086
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1852
Lines: 64

> +void hns_rcbv2_int_ctrl_hw(struct hnae_queue *q, u32 flag, u32 mask)
> +{
> +	u32 int_mask_en = !!mask;
> +
> +	if (flag & RCB_INT_FLAG_TX)
> +		dsaf_write_dev(q, RCB_RING_INTMSK_TXWL_REG,
> int_mask_en);
> +
> +	if (flag & RCB_INT_FLAG_RX)
> +		dsaf_write_dev(q, RCB_RING_INTMSK_RXWL_REG,
> int_mask_en);
> +}
> +
> +void hns_rcbv2_int_clr_hw(struct hnae_queue *q, u32 flag)
> +{
> +	u32 clr = 1;
> +
> +	if (flag & RCB_INT_FLAG_TX)
> +		dsaf_write_dev(q, RCBV2_TX_RING_INT_STS_REG, clr);
> +
> +	if (flag & RCB_INT_FLAG_RX)
> +		dsaf_write_dev(q, RCBV2_RX_RING_INT_STS_REG, clr);
> +}
> +

Why do you need the int_mask_en, clr variables? Why not directly use values?

> +static void fill_v2_desc(struct hnae_ring *ring, void *priv,
....
> +	hnae_set_field(bn_pid, 0x7, 0, buf_num - 1);

Magic values?

> +int hns_nic_net_xmit_hw(struct net_device *ndev,
> +			struct sk_buff *skb,
> +			struct hns_nic_ring_data *ring_data)
> +{

> -	/* If everything has gone correctly network should be the
> +	/**
> +	 * If everything has gone correctly network should be the
>  	 * data section of the packet and will be the end of the header.
>  	 * If not then it probably represents the end of the last recognized
>  	 * header.

What happened to the network style comments?

>  static int hns_nic_poll_rx_skb(struct hns_nic_ring_data *ring_data,
>  			       struct sk_buff **out_skb, int *out_bnum)
> +	/**
> +	 * we will be copying header into skb->data in
> +	 * pskb_may_pull so it is in our interest to prefetch
> +	 * it now to avoid a possible cache miss
> +	 */
> +	prefetchw(skb->data);
> +

Likewise

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/