Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752183AbbKVJak (ORCPT ); Sun, 22 Nov 2015 04:30:40 -0500 Received: from mail-bl2on0139.outbound.protection.outlook.com ([65.55.169.139]:65216 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751223AbbKVJaf convert rfc822-to-8bit (ORCPT ); Sun, 22 Nov 2015 04:30:35 -0500 From: Yuval Mintz To: Salil Mehta , David Miller , "robh+dt@kernel.org" , "pawel.moll@arm.com" , "mark.rutland@arm.com" , "paul.gortmaker@windriver.com" , "ijc+devicetree@hellion.org.uk" , "galak@codeaurora.org" , "catalin.marinas@arm.com" , "will.deacon@arm.com" , "arnd@arndb.de" , "liguozhu@hisilicon.com" , "yisen.zhuang@huawei.com" , "dingtianhong@huawei.com" , "zhangfei.gao@linaro.org" , "huangdaode@hisilicon.com" , "kenneth-lee-2012@foxmail.com" , "mehta.salil.lnk@gmail.com" , "xuwei5@hisilicon.com" , "lisheng011@huawei.com" , "devicetree@vger.kernel.org" , linux-kernel , "linux-arm-kernel@lists.infradead.org" , netdev , "linuxarm@huawei.com" Subject: RE: [PATCH V3 net-next 2/5] net:hns: Add Hip06 "RSS(Receive Side Scaling)" support to HNS Driver Thread-Topic: [PATCH V3 net-next 2/5] net:hns: Add Hip06 "RSS(Receive Side Scaling)" support to HNS Driver Thread-Index: AQHRIwtpmexMqXgUOEKmdjTHoWDJQZ6nyXrA Date: Sun, 22 Nov 2015 09:30:30 +0000 Message-ID: References: <1447966706-16219-1-git-send-email-salil.mehta@huawei.com> <1447966706-16219-3-git-send-email-salil.mehta@huawei.com> In-Reply-To: <1447966706-16219-3-git-send-email-salil.mehta@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Yuval.Mintz@qlogic.com; x-originating-ip: [31.168.140.228] x-microsoft-exchange-diagnostics: 1;CO2PR11MB0086;5:SWFoPhpTtoVEdaSB2oyGuG+zqbqYHeVvRM9OiyfOx5td/mLsQ2NKMke3tPq/PFswEmgOc9gC7GpVjXyYw7dhlASulcolF0KKtwQZLXc1gO6BgVMnQAt4ls7rwyCSYIitsgknWBQxa+LTwj7B2oLiJg==;24:P55+C3kQn9h7ROU0uKIEYO6FP2IDreotC0KczU5bckXaBLeJAyHlv0sRk8TmxwZ5tgjOF1gTwAvpsgM7mcnIZqG4utC23E7yVhSDRfhQnQk=;20:D4qAg/BP56ltdVsemE4W5yAa2H+t2sTzrPyu/PE7Y/KhMXCp0HroJuPnqMXhRwxg6y/9+BhMRZo6kZGK/jcw9i/k3t/2ChR8ts5mKZbAUfL6vN1wvG0JLfOsB0N7jn9cgkpYNNP7EN0T1ReZp8zkYXsdvRf7KNgWCWXgeOa0Qic= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CO2PR11MB0086; x-ld-processed: 0d68a1f9-1490-4d0e-8767-a87dab3ef2ba,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(8121501046)(5005006)(3002001)(10201501046);SRVR:CO2PR11MB0086;BCL:0;PCL:0;RULEID:;SRVR:CO2PR11MB0086; x-forefront-prvs: 076804FE30 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(199003)(189002)(76576001)(5002640100001)(74316001)(33656002)(40100003)(50986999)(10400500002)(106116001)(5007970100001)(5004730100002)(106356001)(5003600100002)(2201001)(5008740100001)(66066001)(5001920100001)(99286002)(105586002)(102836003)(5001960100002)(6116002)(575784001)(101416001)(3846002)(81156007)(107886002)(2501003)(5001770100001)(97736004)(54356999)(86362001)(92566002)(122556002)(76176999)(11100500001)(87936001)(189998001)(2950100001)(2900100001)(77096005)(586003)(921003)(1121003);DIR:OUT;SFP:1102;SCL:1;SRVR:CO2PR11MB0086;H:CO2PR11MB0088.namprd11.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:3;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: qlogic.com X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Nov 2015 09:30:30.2241 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 0d68a1f9-1490-4d0e-8767-a87dab3ef2ba X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR11MB0086 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 787 Lines: 24 > static void hns_ppe_init_hw(struct hns_ppe_cb *ppe_cb) { ... > + /* Set default RSS key and indrection table*/ > + const u32 rss_key[HNS_PPEV2_RSS_KEY_NUM] = { > + 0x6d5a56da, 0x255b0ec2, > + 0x4167253d, 0x43a38fb0, > + 0xd0ca2bcb, 0xae7b30b4, > + 0x77cb2da3, 0x8030f20c, > + 0x6a42b73b, 0xbeac01fa, > + }; > + > + /* set default RSS key and remember it */ > + for (i = 0; i < HNS_PPEV2_RSS_KEY_NUM; i++) > + ppe_cb->rss_key[i] = rss_key[i]; > Is there any reason for the special default key? Why not use netdev_rss_key_fill()? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/