Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751900AbbKVKS1 (ORCPT ); Sun, 22 Nov 2015 05:18:27 -0500 Received: from mail-wm0-f53.google.com ([74.125.82.53]:33090 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751375AbbKVKSZ (ORCPT ); Sun, 22 Nov 2015 05:18:25 -0500 MIME-Version: 1.0 In-Reply-To: <1447951574-26253-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> References: <1447951574-26253-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> Date: Sun, 22 Nov 2015 10:18:24 +0000 Message-ID: Subject: Re: [PATCH] mfd: wm8994: Ensure that the whole MFD is built into a single module From: Peter Robinson To: Charles Keepax Cc: lee.jones@linaro.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1835 Lines: 44 Sorry for the delay in confirmation that it works. Tested-by: Peter Robinson On Thu, Nov 19, 2015 at 4:46 PM, Charles Keepax wrote: > The MFD part of wm8994 consists of three files wm8994-core.c, > wm8994-irq.c and wm8994-regmap.c only wm8994-core.c has a > MODULE_DESCRIPTION / LICENSE. These were clearly intended to be built > as a single module, but currently are not. This will lead to a tainted > kernel when loading modules for wm8894-irq.c and wm8994-regmap.c because > are missing a license. > > This patch fixes this issue by grouping the three files together into a > single module. > > Reported-by: Peter Robinson > Signed-off-by: Charles Keepax > --- > drivers/mfd/Makefile | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile > index a8b76b8..99f93ab 100644 > --- a/drivers/mfd/Makefile > +++ b/drivers/mfd/Makefile > @@ -61,7 +61,8 @@ wm8350-objs := wm8350-core.o wm8350-regmap.o wm8350-gpio.o > wm8350-objs += wm8350-irq.o > obj-$(CONFIG_MFD_WM8350) += wm8350.o > obj-$(CONFIG_MFD_WM8350_I2C) += wm8350-i2c.o > -obj-$(CONFIG_MFD_WM8994) += wm8994-core.o wm8994-irq.o wm8994-regmap.o > +wm8994-objs := wm8994-core.o wm8994-irq.o wm8994-regmap.o > +obj-$(CONFIG_MFD_WM8994) += wm8994.o > > obj-$(CONFIG_TPS6105X) += tps6105x.o > obj-$(CONFIG_TPS65010) += tps65010.o > -- > 1.7.2.5 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/