Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751936AbbKVLcu (ORCPT ); Sun, 22 Nov 2015 06:32:50 -0500 Received: from mail-pa0-f49.google.com ([209.85.220.49]:33211 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751452AbbKVLct (ORCPT ); Sun, 22 Nov 2015 06:32:49 -0500 From: Wenwei Tao To: mb@lightnvm.io Cc: linux-kernel@vger.kernel.org Subject: [PATCH] lightnvm: do device max sectors boundary check first Date: Sun, 22 Nov 2015 19:30:36 +0800 Message-Id: <1448191836-1621-1-git-send-email-ww.tao0320@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1375 Lines: 43 do device max_phys_sect boundary check first, otherwise we will allocate dma_pools for devices whose max sectors are beyond lightnvm support and register them. Signed-off-by: Wenwei Tao --- drivers/lightnvm/core.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c index f659e60..7ecf848 100644 --- a/drivers/lightnvm/core.c +++ b/drivers/lightnvm/core.c @@ -312,6 +312,11 @@ int nvm_register(struct request_queue *q, char *disk_name, list_add(&dev->devices, &nvm_devices); up_write(&nvm_lock); + if (dev->ops->max_phys_sect > 256) { + pr_info("nvm: max sectors supported is 256.\n"); + return -EINVAL; + } + if (dev->ops->max_phys_sect > 1) { dev->ppalist_pool = dev->ops->create_dma_pool(dev->q, "ppalist"); @@ -319,9 +324,6 @@ int nvm_register(struct request_queue *q, char *disk_name, pr_err("nvm: could not create ppa pool\n"); return -ENOMEM; } - } else if (dev->ops->max_phys_sect > 256) { - pr_info("nvm: max sectors supported is 256.\n"); - return -EINVAL; } return 0; -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/