Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751935AbbKVLpi (ORCPT ); Sun, 22 Nov 2015 06:45:38 -0500 Received: from foss.arm.com ([217.140.101.70]:51868 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751452AbbKVLph (ORCPT ); Sun, 22 Nov 2015 06:45:37 -0500 Date: Sun, 22 Nov 2015 11:45:30 +0000 From: Marc Zyngier To: Joshua Henderson Cc: , , Cristian Birsan , Thomas Gleixner , Jason Cooper Subject: Re: [PATCH 02/14] irqchip: irq-pic32-evic: Add support for PIC32 interrupt controller Message-ID: <20151122114530.10bca210@arm.com> In-Reply-To: <1448065205-15762-3-git-send-email-joshua.henderson@microchip.com> References: <1448065205-15762-1-git-send-email-joshua.henderson@microchip.com> <1448065205-15762-3-git-send-email-joshua.henderson@microchip.com> Organization: ARM Ltd X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1228 Lines: 36 On Fri, 20 Nov 2015 17:17:14 -0700 Joshua Henderson wrote: Joshua, Cristian, > From: Cristian Birsan > > This adds support for the EVIC present on a PIC32MZDA. > > The following features are supported: > - DT properties for EVIC and for devices that use interrupt lines > - persistent and non-persistent interrupt handling > - Priority, sub-priority and polariy settings for each interrupt line > - irqdomain support > I haven't reviewed the code yet, but the fact that you allow (and actually request) the interrupt priorities to be encoded in the DT raises some concerns: - Aren't priorities entirely under software control (and hence don't belong in DT)? - More crucially, how do you deal with nested interrupts when you have interrupts running at different priorities? Most parts of Linux cannot cope with that without additional support. Thanks, M. -- Jazz is not dead. It just smells funny. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/