Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752018AbbKVM77 (ORCPT ); Sun, 22 Nov 2015 07:59:59 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:43179 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751458AbbKVM75 (ORCPT ); Sun, 22 Nov 2015 07:59:57 -0500 Date: Sun, 22 Nov 2015 12:59:14 +0000 From: Mark Brown To: Saurabh Sengar Cc: Liam Girdwood , linux-kernel@vger.kernel.org Message-ID: <20151122125914.GL26072@sirena.org.uk> References: <1448006247-4749-1-git-send-email-saurabh.truth@gmail.com> <20151121132202.GE26072@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xtmLDbP6TiKhntQb" Content-Disposition: inline In-Reply-To: X-Cookie: Your domestic life may be harmonious. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 188.29.165.171 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] regulator: of: simplifing the parsing code X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1925 Lines: 48 --xtmLDbP6TiKhntQb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Nov 21, 2015 at 07:41:54PM +0530, Saurabh Sengar wrote: > On 21 November 2015 at 18:52, Mark Brown wrote: > > On Fri, Nov 20, 2015 at 01:27:27PM +0530, Saurabh Sengar wrote: > > No, they can't - the values we set for modes in the DT are defined per > > regulator and we need to translate these into the regulator API > > definitions. > What I want to say is there are only 4 possible values which can be > set for initial_mode and suspend_state modes: > #define REGULATOR_MODE_FAST 0x1 > #define REGULATOR_MODE_NORMAL 0x2 > #define REGULATOR_MODE_IDLE 0x4 > #define REGULATOR_MODE_STANDBY 0x8 No, the regulator can specify *any* value in their bindings - they don't have to be those values, they should be values that are relevant to the hardware rather than values that mean something in the current regulator API abstractions. Things like the values that are specified in the datasheet for example. --xtmLDbP6TiKhntQb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWUbwhAAoJECTWi3JdVIfQF24H/2BaR44A6GVWSEuBx424oLXH nUQpa2T/wMrepLK3otXHFY8IP3ewU9THgs+sqsmJLrGNyABvYV+Dla2Po3myHbsE gMcnN56/b0Zfr3xb5QokMBHxhKvFN7+Eidh91B9a/YuarQG3OwZ/fGwcUzcWRhEa BDP3+NyUbx0u9tAIoxe/OUODzgPVGiMNC88NdjIBINw3cxt4IPYL1Q3QY+hqhBsg EoEqCXrQEy/9YArWwVA1bVCCkbWgtnj0vKLk5BNXTCZ3k/XO08U/gRpWycgWFwrF JXij36+FUBvRG7qG6pp+SHEfJUt6qmUnWXXCTCUoUx6qi3SradPhcCxUDoTIGYA= =yTEn -----END PGP SIGNATURE----- --xtmLDbP6TiKhntQb-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/