Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752498AbbKVTqD (ORCPT ); Sun, 22 Nov 2015 14:46:03 -0500 Received: from down.free-electrons.com ([37.187.137.238]:40101 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752041AbbKVTp7 (ORCPT ); Sun, 22 Nov 2015 14:45:59 -0500 Date: Sun, 22 Nov 2015 20:45:56 +0100 From: Maxime Ripard To: Marcus Weseloh Cc: Rob Herring , Julian Calaby , linux-sunxi , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Mark Brown , devicetree , "Mailing List, Arm" , "linux-kernel@vger.kernel.org" , linux-spi@vger.kernel.org Subject: Re: [linux-sunxi] [PATCH] spi: dts: sun4i: Add support for inter-word wait cycles using the SPI Wait Clock Register Message-ID: <20151122194556.GO32142@lukather> References: <1447948422-4915-1-git-send-email-mweseloh42@gmail.com> <1447948422-4915-2-git-send-email-mweseloh42@gmail.com> <20151120161246.GB21921@rob-hp-laptop> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="8QM4kKE+nfbBA4vJ" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2664 Lines: 73 --8QM4kKE+nfbBA4vJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, Nov 20, 2015 at 05:45:48PM +0100, Marcus Weseloh wrote: > 2015-11-20 17:12 GMT+01:00 Rob Herring : > > On Fri, Nov 20, 2015 at 02:56:34PM +0100, Marcus Weseloh wrote: > >> > (and the wdelay should > >> > arguably be a core-spi thing, not a sunxi thing, but that's a separa= te > >> > discussion) > >> > >> I've been thinking about that, but it seemed to big a change to > >> attempt with my limited kernel hacking experience. > > > > It is not any bigger. You just need to document it in the core binding. > > It would still be read by the drivers using it. >=20 > Julien, Rob: thanks for your comments! Ok, I will make the following chan= ges: >=20 > - remove "sun4i,spi-wdelay" from the sun4i binding and add the > property to the spi-bus.txt binding instead > - remove the comment about the additional 3 cycles from the documentation > - modfy the spi-sun4i driver to take care of the minimum 3 cycle period >=20 > Does that sound right? >=20 > And maybe I could also use a more descriptive name for the property, > maybe "spi-word-wait-cycles"? I don't think it should be in a clock-rate dependant unit. Using micro or nano-seconds would be more appropriate I guess. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --8QM4kKE+nfbBA4vJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWUht0AAoJEBx+YmzsjxAgOM4P/3rXAFSxCo1zmqVCuq4F9Hpm Or+XjIERG9a4zZa11338dxTTsO36Mmilh3ZBHDQDHq7eT4A4NIIGvkKWVxj7JX4Y r2ykxJ9jGpbAZyD4fkEkx0aw0JhYw9CVrfFbPJypmkosNrQ79J/yzfZAKi0a0nx1 uqg+9da0XZl5p3JLOw8XzEFrTnrzoDm3oTFsG/50CIlZYRfuzUnohsdEyDzbt9/3 APjLQgjeXXc+xBpfs3FUd3mrOSS3O6ZeIXPdu1fmWXAV+y8JIxjCMAHfXnC8f7Da Vmma4XcHhH6FMk5UG2CmVwpq3IAXIsvHF3CS+NcwxnXzEQ2uWYBYtESVc8RZ5FcV 6EHG2Dd7RutXvuz6nlI0zXyqayJK4/JsQpGqyHpNZQYdutLhdb9xTRjpBDNW+PSH hbFkLpesS+ISgp0KNRV7m9c2TOVNjjB0vmXmJpRxWeRpNn2JKp7XtmlfoRboT3mF j1IqM+r0i+dMnBWXlpmC+0BGkAUuROz3mmtOLKCN6NeB92kV904QAbO63UxdujmJ oJq+CpfOEH+bMP8hC3mDy2JSABw9KNzyw2WQC1xs3laXCJ7aH8eQP25WDmc4xsXD GIFrsRRGbDUAUVIshS63T9Mi9PEFEDs54RWramgnA7GzLlFCN5GYQwyBAjmXB9Wr /mnSz9BKZZMrxVRoj3pG =2P6Y -----END PGP SIGNATURE----- --8QM4kKE+nfbBA4vJ-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/