Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752738AbbKVVbR (ORCPT ); Sun, 22 Nov 2015 16:31:17 -0500 Received: from mail.kernel.org ([198.145.29.136]:38168 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752206AbbKVVbP (ORCPT ); Sun, 22 Nov 2015 16:31:15 -0500 Date: Sun, 22 Nov 2015 15:31:10 -0600 From: Rob Herring To: Joshua Henderson Cc: linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, Purna Chandra Mandal , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , devicetree@vger.kernel.org Subject: Re: [PATCH 03/14] DEVICETREE: Add PIC32 clock binding documentation Message-ID: <20151122213110.GA16187@rob-hp-laptop> References: <1448065205-15762-1-git-send-email-joshua.henderson@microchip.com> <1448065205-15762-4-git-send-email-joshua.henderson@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1448065205-15762-4-git-send-email-joshua.henderson@microchip.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2515 Lines: 60 On Fri, Nov 20, 2015 at 05:17:15PM -0700, Joshua Henderson wrote: > From: Purna Chandra Mandal > > Document the devicetree bindings for the clock driver found on Microchip > PIC32 class devices. > > Signed-off-by: Purna Chandra Mandal > Signed-off-by: Joshua Henderson > --- > .../devicetree/bindings/clock/microchip,pic32.txt | 263 ++++++++++++++++++++ > 1 file changed, 263 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/microchip,pic32.txt > > diff --git a/Documentation/devicetree/bindings/clock/microchip,pic32.txt b/Documentation/devicetree/bindings/clock/microchip,pic32.txt > new file mode 100644 > index 0000000..4cef72d > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/microchip,pic32.txt > @@ -0,0 +1,263 @@ > +Binding for a Clock hardware block found on > +certain Microchip PIC32 MCU devices. > + > +Microchip SoC clocks-node consists of few oscillators, PLL, multiplexer > +and few divider nodes. [...] > +Required properties: > +- compatible : should have "microchip,pic32-clk". > +- reg : A Base address and length of the register set. > +- interrupts : source of interrupt. > + > +Optional properties (for subnodes): > +- #clock-cells: From common clock binding, should be 0. > + > +- microchip,clock-indices: in multiplexer node clock sources always aren't linear > + and contiguous. This property helps define clock-sources with respect to > + the mux clock node. > + > +- microchip,ignore-unused : ignore gate request even if the gated clock is unused. There is some discussion about this upstream with "critical-clocks" binding. Can you use and wait for that? > +- microchip,status-bit-mask: bitmask for status check. This will be used to confirm > + particular operation by clock sub-node is completed. It is dependent sub-node. > +- microchip,bit-mask: enable mask, similar to microchip,status-bit-mask. We've generally decided not to describe clocks at this level of detail in DT. It's fine though for simple clock trees. This one seems to be borderline IMO. > +- microchip,slew-step: enable frequency slewing(stepping) during rate change; > + applicable only to sys-clock subnode. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/