Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753226AbbKWCrs (ORCPT ); Sun, 22 Nov 2015 21:47:48 -0500 Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]:45890 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753063AbbKWCrq (ORCPT ); Sun, 22 Nov 2015 21:47:46 -0500 Date: Mon, 23 Nov 2015 10:43:30 +0800 From: Jisheng Zhang To: Sebastian Hesselbarth CC: , , , , , , , , , Subject: Re: [PATCH 1/2] arm64: dts: berlin4ct: add I2C nodes for BG4CT Message-ID: <20151123104330.6b9e649c@xhacker> In-Reply-To: <564F8EF3.5010508@gmail.com> References: <1448012821-7413-1-git-send-email-jszhang@marvell.com> <1448012821-7413-2-git-send-email-jszhang@marvell.com> <564F8EF3.5010508@gmail.com> X-Mailer: Claws Mail 3.13.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-11-23_02:,, signatures=0 X-Proofpoint-Spam-Details: rule=inbound_notspam policy=inbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1507310000 definitions=main-1511230049 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3173 Lines: 104 On Fri, 20 Nov 2015 22:21:55 +0100 Sebastian Hesselbarth wrote: > On 20.11.2015 10:47, Jisheng Zhang wrote: > > The Marvell Berlin BG4CT SoC has 4 TWSI which are compatible with the > > Synopsys DesignWare I2C driver. Add the corresponding nodes. > > > > Signed-off-by: Jisheng Zhang > > --- > > arch/arm64/boot/dts/marvell/berlin4ct.dtsi | 52 ++++++++++++++++++++++++++++++ > > 1 file changed, 52 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/marvell/berlin4ct.dtsi b/arch/arm64/boot/dts/marvell/berlin4ct.dtsi > > index cca4c41..39d0676 100644 > > --- a/arch/arm64/boot/dts/marvell/berlin4ct.dtsi > > +++ b/arch/arm64/boot/dts/marvell/berlin4ct.dtsi > > @@ -232,6 +232,32 @@ > > }; > > }; > > > > + i2c0: i2c@1400 { > > + compatible = "snps,designware-i2c"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + reg = <0x1400 0x100>; > > + clocks = <&clk CLK_APBCORE>; > > This patch looks fine to me, except that clock node naming and > clock indices may change. We should really postpone this series > until we worked out clock. Indeed. This is just to sent out for review early, so that we can merge the i2c support once clk is ready. Thanks for review, Jisheng > > Sebastian > > > + i2c-sda-hold-time-ns = <35>; > > + i2c-sda-falling-time-ns = <425>; > > + i2c-scl-falling-time-ns = <205>; > > + interrupts = <4>; > > + status = "disabled"; > > + }; > > + > > + i2c1: i2c@1800 { > > + compatible = "snps,designware-i2c"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + reg = <0x1800 0x100>; > > + clocks = <&clk CLK_APBCORE>; > > + i2c-sda-hold-time-ns = <35>; > > + i2c-sda-falling-time-ns = <425>; > > + i2c-scl-falling-time-ns = <205>; > > + interrupts = <5>; > > + status = "disabled"; > > + }; > > + > > aic: interrupt-controller@3800 { > > compatible = "snps,dw-apb-ictl"; > > reg = <0x3800 0x30>; > > @@ -319,6 +345,32 @@ > > }; > > }; > > > > + i2c2: i2c@b000 { > > + compatible = "snps,designware-i2c"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + reg = <0xb000 0x100>; > > + clocks = <&osc>; > > + i2c-sda-hold-time-ns = <140>; > > + i2c-sda-falling-time-ns = <500>; > > + i2c-scl-falling-time-ns = <220>; > > + interrupts = <6>; > > + status = "disabled"; > > + }; > > + > > + i2c3: i2c@c000 { > > + compatible = "snps,designware-i2c"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + reg = <0xc000 0x100>; > > + clocks = <&osc>; > > + i2c-sda-hold-time-ns = <140>; > > + i2c-sda-falling-time-ns = <500>; > > + i2c-scl-falling-time-ns = <220>; > > + interrupts = <7>; > > + status = "disabled"; > > + }; > > + > > uart0: uart@d000 { > > compatible = "snps,dw-apb-uart"; > > reg = <0xd000 0x100>; > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/