Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753266AbbKWDeP (ORCPT ); Sun, 22 Nov 2015 22:34:15 -0500 Received: from mail-pa0-f47.google.com ([209.85.220.47]:33652 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753101AbbKWDeO (ORCPT ); Sun, 22 Nov 2015 22:34:14 -0500 Date: Mon, 23 Nov 2015 12:35:11 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Kyeongdon Kim , Andrew Morton , ngupta@vflare.org, linux-kernel@vger.kernel.org, sergey.senozhatsky@gmail.com, sergey.senozhatsky.work@gmail.com Subject: Re: [PATCH v2] zram: Prevent page allocation failure during zcomp_strm_alloc Message-ID: <20151123033511.GB7449@swordfish> References: <1448013764-21899-1-git-send-email-kyeongdon.kim@lge.com> <20151123021531.GA10428@bbox> <20151123031400.GA7449@swordfish> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151123031400.GA7449@swordfish> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 612 Lines: 16 On (11/23/15 12:14), Sergey Senozhatsky wrote: > > yes, GFP_KERNEL looks a bit fragile to me too. And may be zcomp_strm_alloc() > and comp->backend->create() deserve GFP_NOFS. I believe I sent a patch doing > this a while ago: https://lkml.org/lkml/2015/6/16/465 > perhaps just __GFP_RECLAIM (GFP_NOIO), not '__GFP_RECLAIM | __GFP_IO' (GFP_NOFS), is better. -ss -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/