Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752815AbbKWHS3 (ORCPT ); Mon, 23 Nov 2015 02:18:29 -0500 Received: from smtp.csie.ntu.edu.tw ([140.112.30.61]:42458 "EHLO smtp.csie.ntu.edu.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751417AbbKWHS2 (ORCPT ); Mon, 23 Nov 2015 02:18:28 -0500 MIME-Version: 1.0 In-Reply-To: <1447930210-27008-1-git-send-email-clabbe.montjoie@gmail.com> References: <1447930210-27008-1-git-send-email-clabbe.montjoie@gmail.com> From: Chen-Yu Tsai Date: Mon, 23 Nov 2015 15:18:05 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/3] rtc: sunxi: fix signedness issues To: LABBE Corentin Cc: Alexandre Belloni , Alessandro Zummo , linux-arm-kernel , Maxime Ripard , Chen-Yu Tsai , linux-kernel , rtc-linux@googlegroups.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 922 Lines: 22 On Thu, Nov 19, 2015 at 6:50 PM, LABBE Corentin wrote: > The variable year must be set as unsigned since it is used with > sunxi_rtc_data_year{.min|.max} and as parameter of is_leap_year() which > wait for unsigned int. > Only tm_year is not unsigned, but it is long. > This patch fix also the format of printing of min/max. (must use %u since > they are unsigned) > > The parameter to of sunxi_rtc_setaie() must be set to uint since callers > give always uint data. > > Signed-off-by: LABBE Corentin Acked-by: Chen-Yu Tsai Would've preferred you not changing the whitespace on the dev_err line though. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/