Date: Mon, 23 Nov 2015 17:13:40 +0900
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Kyeongdon Kim <kyeongdon.kim@lge.com>,
        Andrew Morton <akpm@linux-foundation.org>, ngupta@vflare.org,
        linux-kernel@vger.kernel.org, sergey.senozhatsky@gmail.com,
        sergey.senozhatsky.work@gmail.com
Subject: Re: [PATCH v2] zram: Prevent page allocation failure during
 zcomp_strm_alloc
Message-ID: <20151123081340.GE7449@swordfish>
References: <20151123041847.GA23030@blaptop>
 <20151123074337.GD7449@swordfish>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151123074337.GD7449@swordfish>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 983
Lines: 28

On (11/23/15 16:43), Sergey Senozhatsky wrote:
[..]
> agree. we also would want to switch from vzalloc() to
> 	__vmalloc_node_flags(size, NUMA_NO_NODE,
> 			GFP_NOIO | __GFP_HIGHMEM |  __GFP_ZERO)

[..]
> > So, Kyeongdon's patch will remove warning overhead and likely to
> > make zcomp_stram_alloc successful with vmalloc so I want to
> > roll it out first. And let's add a WARN_ON_ONCE to detect of
> > failure and rethink it when we receive such report.

hm... for k{z,m}alloc() it does reduce the warning overhead, but not
for vmalloc() -> warn_alloc_failed() [in theory]. So I guess, I'll
change vmalloc() to

	__vmalloc(XXX,
		GFP_NOIO | __GFP_NOWARN | __GFP_HIGHMEM | __GFP_ZERO,
		PAGE_KERNEL);

/* passing __GFP_NOWARN */.

	-ss
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/