Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754141AbbKWI6X (ORCPT ); Mon, 23 Nov 2015 03:58:23 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:56134 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754006AbbKWI4m (ORCPT ); Mon, 23 Nov 2015 03:56:42 -0500 X-AuditID: cbfec7f5-f79b16d000005389-4b-5652d4c7bb48 From: Marek Szyprowski To: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Marek Szyprowski , Ruslan Bilovol , Bartlomiej Zolnierkiewicz Subject: [PATCH v7 3/4] usb: gadget: udc-core: remove unused usb_udc_attach_driver() Date: Mon, 23 Nov 2015 09:56:37 +0100 Message-id: <1448268998-4682-4-git-send-email-m.szyprowski@samsung.com> X-Mailer: git-send-email 1.9.2 In-reply-to: <1448268998-4682-1-git-send-email-m.szyprowski@samsung.com> References: <1448268998-4682-1-git-send-email-m.szyprowski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrPJMWRmVeSWpSXmKPExsVy+t/xK7rHrwSFGXQ2mFlsnLGe1eLyrjls FouWtTJbrD1yl92iZ+cJRgdWj52z7rJ79G1ZxejxeZNcAHMUl01Kak5mWWqRvl0CV8arxg2s BRcFKtaffsHWwNjJ18XIySEhYCLx6UQrC4QtJnHh3nq2LkYuDiGBpYwSi679YYdwmpgkFv5b xg5SxSZgKNH1tguoioNDRMBaou9gEEgNs8AURomft58xgdQIC4RJ9O78xgxSwyKgKnGguRIk zCvgLvFq30x2iGVyEv9frgAr5xTwkFh44gvYEUJANb3P77NOYORdwMiwilE0tTS5oDgpPddI rzgxt7g0L10vOT93EyMkWL7uYFx6zOoQowAHoxIPr4Z+UJgQa2JZcWXuIUYJDmYlEd4jW4FC vCmJlVWpRfnxRaU5qcWHGKU5WJTEeWfueh8iJJCeWJKanZpakFoEk2Xi4JRqYDx62OKR+jx2 pqSG3K8JG3YKPD26U6yk5VfGq1XSv1/v/yIX2ag15wiLSoDyDeuzK3dWBP989LMqRer408eK SZrXDvx3SxIsujVvj/2TvMSgLEOr30b1v2dwiS1hLuD4cfbLAh+v62s7Lp41ZfL8e/VAkVqi QWHZPZNPvre4mH/oznkUO0Gz5J4SS3FGoqEWc1FxIgDVPg5REgIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2306 Lines: 73 From: Ruslan Bilovol Now when last user of usb_udc_attach_driver() is switched to passing UDC name via usb_gadget_driver struct, it's safe to remove this function Tested-by: Maxime Ripard Signed-off-by: Ruslan Bilovol Signed-off-by: Marek Szyprowski Tested-by: Peter Chen --- drivers/usb/gadget/udc/udc-core.c | 26 -------------------------- include/linux/usb/gadget.h | 2 -- 2 files changed, 28 deletions(-) diff --git a/drivers/usb/gadget/udc/udc-core.c b/drivers/usb/gadget/udc/udc-core.c index 429d64e..f76ebc8 100644 --- a/drivers/usb/gadget/udc/udc-core.c +++ b/drivers/usb/gadget/udc/udc-core.c @@ -520,32 +520,6 @@ err1: return ret; } -int usb_udc_attach_driver(const char *name, struct usb_gadget_driver *driver) -{ - struct usb_udc *udc = NULL; - int ret = -ENODEV; - - mutex_lock(&udc_lock); - list_for_each_entry(udc, &udc_list, list) { - ret = strcmp(name, dev_name(&udc->dev)); - if (!ret) - break; - } - if (ret) { - ret = -ENODEV; - goto out; - } - if (udc->driver) { - ret = -EBUSY; - goto out; - } - ret = udc_bind_to_driver(udc, driver); -out: - mutex_unlock(&udc_lock); - return ret; -} -EXPORT_SYMBOL_GPL(usb_udc_attach_driver); - int usb_gadget_probe_driver(struct usb_gadget_driver *driver) { struct usb_udc *udc = NULL; diff --git a/include/linux/usb/gadget.h b/include/linux/usb/gadget.h index 63963c2..ce2188d 100644 --- a/include/linux/usb/gadget.h +++ b/include/linux/usb/gadget.h @@ -1121,8 +1121,6 @@ extern int usb_add_gadget_udc_release(struct device *parent, struct usb_gadget *gadget, void (*release)(struct device *dev)); extern int usb_add_gadget_udc(struct device *parent, struct usb_gadget *gadget); extern void usb_del_gadget_udc(struct usb_gadget *gadget); -extern int usb_udc_attach_driver(const char *name, - struct usb_gadget_driver *driver); /*-------------------------------------------------------------------------*/ -- 1.9.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/